Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4835773ybb; Tue, 14 Apr 2020 15:14:43 -0700 (PDT) X-Google-Smtp-Source: APiQypKiAUNeZvZhvZhxLGzUAMzikqBj+4LZlWqLB1N7bPvsVzCDobHI/HoGkpPnZ/uDxaYGOTOX X-Received: by 2002:a17:906:2988:: with SMTP id x8mr2219680eje.16.1586902483145; Tue, 14 Apr 2020 15:14:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586902483; cv=none; d=google.com; s=arc-20160816; b=mB6vm8yobCO7qXK8ccVfq0Dk+16pOEuf2zKkh/fOefG/BVW97/by0VkG0S6HFU4v0o NtV/te1Hk1eyQ625B1pRc6lCZex3FFt4+Osw7UWoAW2wg+AZ5iQp3yZjYt7Vev+W4t7J nZ4h+Sj0FU+bfXIhpSmVgg4oQ+e2GSSLjjd7Ri7nyvy/FkSZvpkmT0mZuWNgb6w5dD3b KvpmVcjrKPTPOwm75Qt0iiAka78esI4S72JvfgZNJGG9xuhxq+6tQiWG+9Kuz5bYzXYj IjNbtccIiw7vxXK9EKV1qoJIffSBMi0mC8AAdda7HCNvv+JIzF6kwKyFyQFHtdnfy8TM PGHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:from:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:date; bh=PpvFaXXu3HqmXhlJidxWaBUlH0/BKHgcaJcwpxQOiNg=; b=OwmXehwd2Vqj7BHWIQzs7K+Ty5RsChut5cxu5OLjajvLbNMxpE8jz/DG5hSuzyjco7 dxGn3qBuoN08Z5+vHOYk6Vi4iEDb0IRmiE4i3vU7Nd1bD7jIj9XA1TTpTlnItsIbimNs VLDfuLE//QB0FTBdlRnACUnV36Da07fZgX4BXRdMlHdfvne0RP1boAfQazHG0Lm1/RLv vOKjQd4MWkwNapABI3LwtXe4uKfqjX7+PCUIanQyUex+/1BbBsGN1z86lCkXGj6zOWxd /4IUtuh/IuJS5ZqJBGELL3VAJud/GruWjLDY06BFaTO8rDh+1sfNqn88ZVAhj8CnNbnP U9Tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n12si1461058eds.584.2020.04.14.15.14.08; Tue, 14 Apr 2020 15:14:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728725AbgDMT3J (ORCPT + 99 others); Mon, 13 Apr 2020 15:29:09 -0400 Received: from fieldses.org ([173.255.197.46]:46268 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728291AbgDMT3I (ORCPT ); Mon, 13 Apr 2020 15:29:08 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 5B3331C22; Mon, 13 Apr 2020 15:29:07 -0400 (EDT) Date: Mon, 13 Apr 2020 15:29:07 -0400 To: Jason Gunthorpe Cc: Chuck Lever , Leon Romanovsky , Linux NFS Mailing List , linux-rdma@vger.kernel.org Subject: Re: [PATCH v1 3/3] svcrdma: Fix leak of svc_rdma_recv_ctxt objects Message-ID: <20200413192907.GA23596@fieldses.org> References: <20200407190938.24045.64947.stgit@klimt.1015granger.net> <20200407191106.24045.88035.stgit@klimt.1015granger.net> <20200408060242.GB3310@unreal> <20200409174750.GK11886@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409174750.GK11886@ziepe.ca> User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Apr 09, 2020 at 02:47:50PM -0300, Jason Gunthorpe wrote: > On Thu, Apr 09, 2020 at 10:33:32AM -0400, Chuck Lever wrote: > > The commit ID is what automation should key off of. The short > > description is only for human consumption. > > Right, so if the actual commit message isn't included so humans can > read it then what was the point of including anything? Personally as a human reading commits in a terminal window I prefer the abbreviated form. I haven't been doing the redundant parentheses and quotes either. Was that dreamt up by an Arlo Guthrie fan? ("KID, HAVE YOU REHABILITATED YOURSELF?") --b.