Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp975866ybz; Wed, 15 Apr 2020 23:55:35 -0700 (PDT) X-Google-Smtp-Source: APiQypLNGY3MBGgX3z1882ngFbdjbrjKrXu8nEXSYP7r5C4YVVBHXBQVp+fI3L/Al5JF2gP1lK0N X-Received: by 2002:a17:906:ecb8:: with SMTP id qh24mr8190008ejb.299.1587020135410; Wed, 15 Apr 2020 23:55:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587020135; cv=none; d=google.com; s=arc-20160816; b=Q2W2m++ZDp2tk57mcilpi6t0SDrpKglhenbPEKxBmx7kRnMk329SVdSw7LDvSTl+bt wTpPQ43w2Y078bqajTJuP6aAABinlb6MYTH1IHeKK1QgVZqATmgtLEsCcrdftF8WtrAD hj8Yr+lRe4j7XHg1IRvTk4DUUCkYc1rK62dCiA3S2Vo9CZTIf1rxBv1JQDa+wyJWRkOg HmcvjHIWX9t0b/iUomgMWiUFSAcLMYzFJTSsk+GctFxYz7kTAY5QXiiOjGcV/gjlgKKM GZ5GHbWdyy61nHD0Q2eeGQ6iBRhcUg7R5+jsEIcThwT65ya0tNJGjCvJJh81d8Zq9AGu XteQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=PhktM7xkiFtBGJ6dx8UYLKoYK1Fp1IPWa9qQEpZldmY=; b=Q2rHEcedS3XYEdGwQssmMeFEhu4n7zwilJES2ORkLGp8zJRY64MyJLicFiVq2Plvoc TE5S9R4hau1usvU/8TQB8/v10V839tueU3LPoaRCeqzxEL58YUGPWT0TCugeTY/aOQhw pcKY3HL5Y5XlPp9IHcZCowpDkgVNxawtiiXi5ckwKpd1lh5lOdX4FosOn+iQEa9624kO JQ5GyyKjIiket3P6JtKSD5RMg2q5bhWU9n+/Ih/81zwxF8e0Ge9HVjfkaAdk+a9yzGQs UI6zkxKPovIDPkQTWmoW3ZmuMdAvUEwLlanxfcdJ4NoyU7hOq6uwPfaJbodcAKyONopM dmYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qUXYZs7y; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n16si1023452ejl.134.2020.04.15.23.55.01; Wed, 15 Apr 2020 23:55:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qUXYZs7y; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437275AbgDPGyb (ORCPT + 99 others); Thu, 16 Apr 2020 02:54:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2437468AbgDPGy1 (ORCPT ); Thu, 16 Apr 2020 02:54:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 536CDC061A0C; Wed, 15 Apr 2020 23:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PhktM7xkiFtBGJ6dx8UYLKoYK1Fp1IPWa9qQEpZldmY=; b=qUXYZs7ybgSXUPkdc9bshfC+TP YyTj+O9gfG0xSQUFcPVmDbSivTYGU6T8/JuO8e+CniEHH5g4brZ+JIjPGkHNQ1Qgd9FQuMnHRH9DA pYH8fUNhGvOZjF3ofrnhGaElg7f6EIZCxYZ7ErJZHnaKVw1IhmGBjHgHu9iYquVmRmQq3Z1R2CDwX 8jyvhp/HLmJlwW8wPJnyfCNCsNlth/WA6d2FKQ0szNVS+hZYuffh7eyhNWbHofsN5HjZc+KXsnQj5 hphNYzS+rYK+nICKfsydWgXQr87HpsubyYPPTg9E5LA0ddCCMxD5mqZ3UUxLFLm3cEFXcundK/gP2 +gLPWsqw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOyPi-00010l-Cc; Thu, 16 Apr 2020 06:54:18 +0000 Date: Wed, 15 Apr 2020 23:54:18 -0700 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , "Anna.Schumaker@Netapp.com" , Andrew Morton , Jan Kara , Michal Hocko , linux-mm@kvack.org, linux-nfs@vger.kernel.org, LKML Subject: Re: [PATCH 1/2 V3] MM: replace PF_LESS_THROTTLE with PF_LOCAL_THROTTLE Message-ID: <20200416065418.GA1092@infradead.org> References: <87tv2b7q72.fsf@notabene.neil.brown.name> <87v9miydai.fsf@notabene.neil.brown.name> <87ftdgw58w.fsf@notabene.neil.brown.name> <87wo6gs26e.fsf@notabene.neil.brown.name> <87tv1ks24t.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tv1ks24t.fsf@notabene.neil.brown.name> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > + if (current->flags & PF_LOCAL_THROTTLE) > + /* This task must only be throttled based on the bdi > + * it is writing to - dirty pages for other bdis might > + * be pages this task is trying to write out. So it > + * gets a free pass unless both global and local > + * thresholds are exceeded. i.e unless > + * "dirty_exceeded". > + */ This is not our normal multi-line comment style. The first line should be just a /* Otherwise this looks good.