Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1732877ybz; Thu, 16 Apr 2020 14:38:34 -0700 (PDT) X-Google-Smtp-Source: APiQypJvtdSVoQGA9c3vFtMoJ0b4tuBQ1WoRtof2LTdrhRptf+QgnyFabMb6QZYF0mOindca9S0p X-Received: by 2002:a50:b412:: with SMTP id b18mr240680edh.42.1587073113859; Thu, 16 Apr 2020 14:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587073113; cv=none; d=google.com; s=arc-20160816; b=eDOs+JDfsG+00NUw3sx6jhx3lcK7iKVOxEcJNJnNBmyvgTeDyeTEUTdjhsikRY6/Na z91iINxnKcgtBK6ug/8+iwZJL3X/cL2bUpXhDOYoTSJoAn9hNpp+l4RWSSP71gS3bOd0 WUTzbmigjhvdbqVVtxERTQSBjI5ZNpQJWRTXs6gNZS2NTT77LB4bGbYdfCkw5EkBLGDJ GR0AuUyeLx87TAJRY0/bEpOq0JyE3YPHqgJEp6aJpPhYyEytKwZZY68bB6R7dqRTjVW1 aWh2LU7A51Pwa89YBv2y7Thm3f90r9XJmteBS8hzHAzxBSGy+neaYsYXcYBCMGLH524Y OHIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Jxpxze/Q7jbR+b4pP27n26lQcfNhSCz3ozXZNoGGWe8=; b=R/Q7KTaLXvzNfU/zAoYwKURKUavVX0rC+1ZLyf9FicsUEDrMLSbqZparEjG//W/jZ9 TP/SbdxlJG7TwKUuaISRD5o02SSqhdszuVlIY55HVZ7N4Mb+//ktoM2/6eFb6wEzxhw3 3wyI+XpBosVt6AlHPaNVdTl/25iKc3Bhk3Ncj9RCYt1tAGlcb4oVJQ/zzJ4zbCfcZvSe /nTJ/wGEC/IkmzOrEk1j5lcN+43FRLRnUTtrVJN3yAt05yazuQUNmIGSgAA+GLBZH83z mZl865n2/C+5PPQSM/EBLyVRYvOCvJjjduUz1FgDRObkdwSXqEeRFT+ai5Lc6duXeH65 BvRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=liL+Fgkg; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si13679949ejj.79.2020.04.16.14.37.53; Thu, 16 Apr 2020 14:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=liL+Fgkg; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbgDPVhC (ORCPT + 99 others); Thu, 16 Apr 2020 17:37:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:49920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbgDPVhB (ORCPT ); Thu, 16 Apr 2020 17:37:01 -0400 Received: from localhost.localdomain (c-68-36-133-222.hsd1.mi.comcast.net [68.36.133.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BBC6206D5; Thu, 16 Apr 2020 21:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587073021; bh=Cfi0+yFzJtQK/nhYT+xLhV32M3eu6Haf2f7Ia1tbhnQ=; h=From:To:Cc:Subject:Date:From; b=liL+FgkgbMS6OSJCt4/Y28tEjenmatPCsivUONuiDU0HobT68XnhDhBmJBxiAWr7u 2Tccj8GT4WE3wL6UaE/i+pj8MHPxcAI9A7CAIUPGUOH2f8bDSYaoVdxuSLDTeziNhW dnxLd3Tl5EEGPBgllR2ciIwJV0VyyTLFaOo65QSs= From: trondmy@kernel.org To: Steve Dickson Cc: linux-nfs@vger.kernel.org Subject: [PATCH] Fix a buffer overflow in qword_add() Date: Thu, 16 Apr 2020 17:34:53 -0400 Message-Id: <20200416213453.80110-1-trondmy@kernel.org> X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust Don't allow writing beyond the end of the buffer. Signed-off-by: Trond Myklebust --- support/nfs/cacheio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/nfs/cacheio.c b/support/nfs/cacheio.c index 126c12831668..70ead94d64f0 100644 --- a/support/nfs/cacheio.c +++ b/support/nfs/cacheio.c @@ -42,7 +42,7 @@ void qword_add(char **bpp, int *lp, char *str) if (len < 0) return; - while ((c=*str++) && len) + while ((c=*str++) && len > 0) switch(c) { case ' ': case '\t': -- 2.25.2