Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp285374ybz; Fri, 17 Apr 2020 00:52:55 -0700 (PDT) X-Google-Smtp-Source: APiQypIhaH0sTcvjl/wkFOq5pWlWBxlM8C8WeRNiQTA61PC5Rhk7+/EFiZUcdBAmITgsTQbbSTnU X-Received: by 2002:a17:906:164f:: with SMTP id n15mr1729923ejd.322.1587109975137; Fri, 17 Apr 2020 00:52:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587109975; cv=none; d=google.com; s=arc-20160816; b=tmoCcXSA1p7ao51Oq9BA8ItQ1sanYMmuxPDmPzPQroqewPtdRxp7r6aVMRDHLRd4Oq lXr8sAh2Y6U7wRHIY3kPPROh9WX7B58O25JzA7BKPU167CuDspfI5M2NU3Ra8FJdbDVn H+0WS+G3j8BJkxZFzcEdCf6uyMZj1OYnXcW3e2h7UczdGPwXQsFCIW1gMmhgXbxCl7Dl 7RXfW0PTRac8q7a3a/FtSXt9Z1S9jl+1HoBYgZ51ro+5dzeUh8Wt2naN+OAKv830prvz FW1MACoLYeZmH3oj+dUglVHAKCWTHfFvTZ8r1wv8Cwjm6AvUfU08hONiatGzQCmfH+y1 4V8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=9MNSuC5hg6YPkaUcYIiqoAvVuBbZW4lemK9V50L0u08=; b=sM2DeBqhQUPX2/fIKaa+aPqROY1Z/PEMKqDaUDmKmf+5/D2GJY2QMZdUYrHGlU6v24 JX8HIaFa7r2Qtwckz6NA0cMn236hAshEA8OJfgbf53V2hDzzVGjMEW4PVUkCSX3uTrMw HK8hlKd2OLEM8k6lqwMyqNfPy8LnELCIVV5bxPV1c2+80UZ91shbIc/L+l8pO3qNSOEI ojVvXT1RMDACCArIV0vaAqhJSIMW5TcVCkTI8s+R1Zfdc1OtdAImqu3XRVATidpuhyUh vY4k4pI9q027LtnBrYaSytxC8ygoSdkZicvCJ/abG3i3uKlBdNfmpn0WPiDSBLg6/xGW BHVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Fb4A1FWh; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c7si8051990edq.184.2020.04.17.00.52.27; Fri, 17 Apr 2020 00:52:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Fb4A1FWh; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729106AbgDQHvw (ORCPT + 99 others); Fri, 17 Apr 2020 03:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729042AbgDQHvw (ORCPT ); Fri, 17 Apr 2020 03:51:52 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FC31C061A0C; Fri, 17 Apr 2020 00:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9MNSuC5hg6YPkaUcYIiqoAvVuBbZW4lemK9V50L0u08=; b=Fb4A1FWhj8E9zcaEYfE85nKg6P YLH6oMxcEIRi/phD3Wef+KVxWUVRPUMGk4r2ue+r3QpdXUQS1GSP8RixvZX1Yl0qSI+aGARfN1ulq ROJ0rEjLtBXP2Nu2x/JJeH5z40Kc0NKxjlDd3CQlVwNCVNDblxXvD2+efokonBLzHfCs7FFDS6/5c /Zvzm5gZz9Pj17rT4hbw5syuRXrgzyE0CfAcvPHUmcLfdimzqUvWk6EaVEFcfSpjFI1i+fPIUSQZ5 qwu/n8Pe1D6gRhqI1HeZpPW2YWCYpYTJT/V4kUqTVYGJ5lcHP/76l31wBtArfzO4Oo6tSHGQApbLP /jZFwyZQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPLmw-0008Id-UU; Fri, 17 Apr 2020 07:51:50 +0000 Date: Fri, 17 Apr 2020 00:51:50 -0700 From: Christoph Hellwig To: Max Kellermann Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com, bfields@redhat.com, tytso@mit.edu, viro@zeniv.linux.org.uk, agruenba@redhat.com, linux-kernel@vger.kernel.org, Jan Kara , stable@vger.kernel.org Subject: Re: [PATCH v3 3/4] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n Message-ID: <20200417075150.GC598@infradead.org> References: <20200407142243.2032-1-mk@cm4all.com> <20200407142243.2032-3-mk@cm4all.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200407142243.2032-3-mk@cm4all.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > +#ifdef CONFIG_FS_POSIX_ACL > #define IS_POSIXACL(inode) __IS_FLG(inode, SB_POSIXACL) > +#else > +#define IS_POSIXACL(inode) 0 > +#endif Looks good, but I'd simplify this down to: #define IS_POSIXACL(inode) \ (IS_ENABLED(CONFIG_FS_POSIX_ACL) && __IS_FLG(inode, SB_POSIXACL))