Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [Libtirpc-devel] [PATCH] pkg-config: use the correct replacements
 for libdir/includedir
To:     Eli Schwartz <eschwartz@archlinux.org>,
        libtirpc-devel@lists.sourceforge.net
Cc:     linux-nfs@vger.kernel.org
References: <20200419075201.1161001-1-eschwartz@archlinux.org>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <3c90187c-8b02-9d74-3890-63dd36c2c56f@RedHat.com>
Date:   Mon, 20 Apr 2020 13:47:44 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200419075201.1161001-1-eschwartz@archlinux.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Hello,

On 4/19/20 3:52 AM, Eli Schwartz wrote:
> They are defined pkg-config variables for a reason, let's reuse them as
> is the intended usage of pkg-config. This ensures various pkg-config
> features continue to work as expected.
Just curious... What pkg-config feature does this fix?

steved.

> 
> Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
> ---
>  libtirpc.pc.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libtirpc.pc.in b/libtirpc.pc.in
> index 38034c5..863950f 100644
> --- a/libtirpc.pc.in
> +++ b/libtirpc.pc.in
> @@ -9,4 +9,4 @@ Requires:
>  Version: @PACKAGE_VERSION@
>  Libs: -L@libdir@ -ltirpc
>  Libs.private: -lpthread
> -Cflags: -I@includedir@/tirpc
> +Cflags: -I${includedir}/tirpc
>