Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1886125ybz; Thu, 23 Apr 2020 07:45:15 -0700 (PDT) X-Google-Smtp-Source: APiQypIgxIRX4QbQo+ntE8PjYe01/6B0n8nXd7knfdjDnxuEgF3ojKYNdvh4GzyLtFJ2+dVdB008 X-Received: by 2002:a50:a9c4:: with SMTP id n62mr2799176edc.267.1587653115572; Thu, 23 Apr 2020 07:45:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587653115; cv=none; d=google.com; s=arc-20160816; b=VXh4VjPdrZHhz4zSZvtAW1DKqOrj2oBp+2bawx+VhQdV2+LCauwrKeqouxxs6HGqTf iTuZKQGwwAONrOWMRy6JNV7+iw5t+Ut/VdpvqnnlTejgmJBIoICdJE7DSQz+XdTLg+47 46cGVyIeFeQcS0hEyXTLOEB2VnDjfV4Mm0s0/f07EZnU81OyPH2aUvmF9WRSVPHtYmtj nG+jDzE5kU9xd7oGhbE0rBruavupwkgH0E0Zqc/uBKtvZ61vBPfNWFgMMMdUbofk+xMO deTvQFFP2CcWvSypzPtau9mLuZX2dVtkuCSdE4q+QGTqlPL8vFr+oHCjGBj/BVhowtGj e71A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=U0l3rZSHeT3B77iPKt/LP/tNMNy58XvjcMskI+WbSbA=; b=SlahIl+UyMx88fa3Biv9ZmCkHRgc6Fwk8jpTRB0xVm9e10QszdlWnADgew8uYRX3AI BlP1YoV+ne6mVb+Y2IiHJO/7ztb9GCgo9dU8849NFbP2jv8QO5cNT4yf4Er9Qapruv6F Lbk/7atsbXiyolRS2yGNatssc89QvliJJZ0rzlIaKvVXNKMa06MljBZ3o3iLRNexaNsc enPrDFPUT9U/+/FyA1XQVBSnNXiFlQCAmQ6BBdlTe+3maoEN8+XhcGi1bwbgUmuMpisB VdR8XQ6vPnPqEW8bbDMkf9j/6M2Q8f0mJ0Sb7q9oQarnMYAN7MC3Gm4xbe9zXv3ljfbR ZSyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=xLXUAkhh; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m24si1253599edr.227.2020.04.23.07.44.51; Thu, 23 Apr 2020 07:45:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=xLXUAkhh; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728266AbgDWOo0 (ORCPT + 99 others); Thu, 23 Apr 2020 10:44:26 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42212 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726458AbgDWOo0 (ORCPT ); Thu, 23 Apr 2020 10:44:26 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03NEd3Io089155; Thu, 23 Apr 2020 14:43:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=U0l3rZSHeT3B77iPKt/LP/tNMNy58XvjcMskI+WbSbA=; b=xLXUAkhhUqCaMMKBL/8CKYV2snocLN1vKd5SmZdd+WfIqb7SGwPjGLCCw9XydX2IcDDZ CJ/3IEwHFOn0WRsuHh+qhqCGbnKKm2ajh+D6HE94/lcrvhBZzi9xl+6D9w9Zoax+2uMP OkKPdJWoNsaAgqYu8ckooRzLXwXrWJg+HJH4SCDfe5tq/uJhsMaoNbBiLGdQzpAnm2du 874jQ7qMyVRABNGe26WfHbSI38ncihMzY5oX2nz0BkNLaznc0iCKtgsMXbrkuXAsuabf 1N9KLXOygH2J526rEnfPAo23t+2p779f8WZMQg344ZMb6LDlBvCy0zDXYBrquesepMYt vg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 30k7qe1qcd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Apr 2020 14:43:42 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03NEcUOi038314; Thu, 23 Apr 2020 14:43:42 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 30gb1muep4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Apr 2020 14:43:42 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 03NEhbKw031862; Thu, 23 Apr 2020 14:43:37 GMT Received: from anon-dhcp-153.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 23 Apr 2020 07:43:36 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH -next] xprtrdma: Make xprt_rdma_slot_table_entries static From: Chuck Lever In-Reply-To: <1587625802-97494-1-git-send-email-zou_wei@huawei.com> Date: Thu, 23 Apr 2020 10:43:34 -0400 Cc: Trond Myklebust , Anna Schumaker , davem@davemloft.net, kuba@kernel.org, Bruce Fields , Linux NFS Mailing List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <30D769C6-2F48-40C7-BDFC-4CD3398DE852@oracle.com> References: <1587625802-97494-1-git-send-email-zou_wei@huawei.com> To: Zou Wei X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9599 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004230117 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9599 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 mlxscore=0 clxscore=1011 malwarescore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004230117 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > On Apr 23, 2020, at 3:10 AM, Zou Wei wrote: >=20 > Fix the following sparse warning: >=20 > net/sunrpc/xprtrdma/transport.c:71:14: warning: symbol = 'xprt_rdma_slot_table_entries' > was not declared. Should it be static? >=20 > Reported-by: Hulk Robot > Signed-off-by: Zou Wei Reviewed-by: Chuck Lever > --- > net/sunrpc/xprtrdma/transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/net/sunrpc/xprtrdma/transport.c = b/net/sunrpc/xprtrdma/transport.c > index 659da37..9f2e8f5 100644 > --- a/net/sunrpc/xprtrdma/transport.c > +++ b/net/sunrpc/xprtrdma/transport.c > @@ -68,7 +68,7 @@ > * tunables > */ >=20 > -unsigned int xprt_rdma_slot_table_entries =3D RPCRDMA_DEF_SLOT_TABLE; > +static unsigned int xprt_rdma_slot_table_entries =3D = RPCRDMA_DEF_SLOT_TABLE; > unsigned int xprt_rdma_max_inline_read =3D RPCRDMA_DEF_INLINE; > unsigned int xprt_rdma_max_inline_write =3D RPCRDMA_DEF_INLINE; > unsigned int xprt_rdma_memreg_strategy =3D = RPCRDMA_FRWR; > --=20 > 2.6.2 -- Chuck Lever