Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Tom Stellard <tstellar@redhat.com>
To:     linux-nfs@vger.kernel.org
Cc:     Tom Stellard <tstellar@redhat.com>
Subject: [PATCH 1/2] Fix -Wformat-nonliteral warning
Date:   Fri, 24 Apr 2020 18:39:05 +0000
Message-Id: <20200424183906.119687-2-tstellar@redhat.com>
In-Reply-To: <20200424183906.119687-1-tstellar@redhat.com>
References: <20200424183906.119687-1-tstellar@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

xcommon.c:101:24: error: format string is not a string literal [-Werror,-=
Wformat-nonliteral]
     vfprintf (stderr, fmt2, args);
                       ^~~~
---
 support/nfs/xcommon.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/support/nfs/xcommon.c b/support/nfs/xcommon.c
index 3989f0bc..1d04dd11 100644
--- a/support/nfs/xcommon.c
+++ b/support/nfs/xcommon.c
@@ -94,13 +94,11 @@ xstrconcat4 (const char *s, const char *t, const char=
 *u, const char *v) {
 void
 nfs_error (const char *fmt, ...) {
      va_list args;
-     char *fmt2;
=20
-     fmt2 =3D xstrconcat2 (fmt, "\n");
      va_start (args, fmt);
-     vfprintf (stderr, fmt2, args);
+     vfprintf (stderr, fmt, args);
+     fprintf (stderr, "\n");
      va_end (args);
-     free (fmt2);
 }
=20
 /* Make a canonical pathname from PATH.  Returns a freshly malloced stri=
ng.
--=20
2.25.3