Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2937720ybz; Mon, 27 Apr 2020 07:16:06 -0700 (PDT) X-Google-Smtp-Source: APiQypIeu1vrXWIR5btmUWr4d5XMblJaAuudygvfcfqDLXrr0LsOnFAwcTahokzmTpS2rpnCUb6L X-Received: by 2002:a17:906:130d:: with SMTP id w13mr19472861ejb.253.1587996966275; Mon, 27 Apr 2020 07:16:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587996966; cv=none; d=google.com; s=arc-20160816; b=eZsb06MqyIlQVClPd2oxcsYaM2P/Osm2OGBmkWyzuO0CuG3/IystGs/twpXqkymW85 xDUrZWOEU2a8YM5T/Zc0iZX5RNb1/iPv9J2opFEOqSsWaTQCbXy1ta2FnslEjp7JZIRg mPm25qs46wWwbDYHldLKTMmfPLMb7I604b0id4KFUJ+53AF3MuLyGXUed8jsFB8Ae6lX 7U0+RAtxr00izpxXz8EwtiWId3FX3SEE473q0U8Fn3YvRwahkCeMWU6HFp/IstH/KOna Yg3iPB2b1w8XqWsbl6bWyb0K7SgvAR4R+j/23m8sPUnY9qq03fSGYEnrunDs1olCr6rN 8WTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=e3orOv4UV0UUot/Ua4Hzf+JbsqQyQDP5B+jzSFOMsFU=; b=LVec4qHbViXtQiEQX0GLUAvZKBKpO2K0t3eGdF9BLSGoBIZWoWMNzZOCG9krv3RPPQ zyiQQIV5qFm58115kiCmE1Y+3LNVfyEiiI/p0QwveOrymEVJ2bMX3gqagKm9jesq8FJA MtRsqzqIEx03iV7fSyP5f5vK7YZ8P11FlBkCI5KXT4eITgDHbWnqUoXyTWSY10m+8LYL /mUTQot1bGeOWevbcuRBYanurP+JOytQJpuH9T3KHosLXFfkWA0MM8RKDlV3ByYSntcv iRhq+WTS38QkyLma74lCGUmuNC/AiLvy39re4/MTRxHEPR74pRD99eE8y1wZpglJ/sPS BQIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Dm7vS3H6; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi13si991804edb.449.2020.04.27.07.15.32; Mon, 27 Apr 2020 07:16:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Dm7vS3H6; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbgD0OOV (ORCPT + 99 others); Mon, 27 Apr 2020 10:14:21 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:40080 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727022AbgD0OOU (ORCPT ); Mon, 27 Apr 2020 10:14:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587996859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3orOv4UV0UUot/Ua4Hzf+JbsqQyQDP5B+jzSFOMsFU=; b=Dm7vS3H6ixn4KSyTdXmu34DAWYAszmuSNJnqsxLpAGibDsksdyyC+u/L1f2ys5UR74jKaE MQFBAwRy7bS8AHeUuimoo6v/OeIWzimJiH/M//Yy5ZJvIXGWxB48KPTl2BoJzeaKgecoeE uaa0M5oYrOGDIeZNhdl3ZjGaF5Lv7Ao= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-76A4-QV6MRaMfWf3thZIPA-1; Mon, 27 Apr 2020 10:14:15 -0400 X-MC-Unique: 76A4-QV6MRaMfWf3thZIPA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1445818FE860; Mon, 27 Apr 2020 14:14:14 +0000 (UTC) Received: from madhat.boston.devel.redhat.com (ovpn-112-163.phx2.redhat.com [10.3.112.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id A493027CC9; Mon, 27 Apr 2020 14:14:13 +0000 (UTC) Subject: Re: [Libtirpc-devel] [PATCH v2] pkg-config: use the correct replacements for libdir/includedir To: Eli Schwartz , libtirpc-devel@lists.sourceforge.net Cc: linux-nfs@vger.kernel.org References: <20200419075201.1161001-1-eschwartz@archlinux.org> <20200420182635.1488536-1-eschwartz@archlinux.org> From: Steve Dickson Message-ID: <69f52eaf-52dd-9729-af35-a2c5f6a398b1@RedHat.com> Date: Mon, 27 Apr 2020 10:14:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200420182635.1488536-1-eschwartz@archlinux.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 4/20/20 2:26 PM, Eli Schwartz wrote: > They are defined pkg-config variables for a reason, let's reuse them as > is the intended usage of pkg-config. This ensures various pkg-config > features continue to work as expected. > > Signed-off-by: Eli Schwartz Committed... (tag: libtirpc-1-2-7-rc1) steved. > --- > > v2: forgot the Libs change > > libtirpc.pc.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libtirpc.pc.in b/libtirpc.pc.in > index 38034c5..d2c7878 100644 > --- a/libtirpc.pc.in > +++ b/libtirpc.pc.in > @@ -7,6 +7,6 @@ Name: libtirpc > Description: Transport Independent RPC Library > Requires: > Version: @PACKAGE_VERSION@ > -Libs: -L@libdir@ -ltirpc > +Libs: -L${libdir} -ltirpc > Libs.private: -lpthread > -Cflags: -I@includedir@/tirpc > +Cflags: -I${includedir}/tirpc >