Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4435455ybz; Tue, 28 Apr 2020 11:15:37 -0700 (PDT) X-Google-Smtp-Source: APiQypKau2+a2fhGQ1c4c8q/+AKsA6lO+Fg4FUA0zUuQg7AqTT0jjFJevIz7BnQte7loxmkxZlDO X-Received: by 2002:a05:6402:204b:: with SMTP id bc11mr23227198edb.114.1588097737068; Tue, 28 Apr 2020 11:15:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588097737; cv=none; d=google.com; s=arc-20160816; b=aLsSz1tEStKvE7AxeSPgtPTNctvB63MyyiQmWMPjoHtMMEFM+5wXEAau6rDsfKr4g5 ApYWP1SS0Pgobu8cqM0/jk1Z1Q9SUh1vxWRwVbdvNLSHDcsL/iGdZpCJolgGPgm4a0LM 8eX8bYMWbuc0IUJRNRttfCyFCu5VUjiSK/ePIqce+V8IV07PEbRc9PRb/bpzZECd3HFt 4vaOerYvr0ATwSKtbeoVrvutW+vswYin/f/LAMpGAlr4q6jSHTkjRpXmOjyNBn511wIS M2lzzEynmrJjoTI/FPFl7iA9FWU03dnIp5e9tDgAVuwlq91S8yXILK1Q8dzjQ8rm6LBe gfjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:subject:message-id:date:from :mime-version:dkim-signature; bh=pxjdZpqcamLG72XCoSC0lwx2EPV6FSiZswEBQmaksJg=; b=K+2e1NR/XnCFit3LHeYK5TjvycuWrLGnALGagcEnsTdfk8CX+5ob7ECvQeBejTGFf6 1ZvSqrvKhWRGZS/EiXPl7LLBSP/pU31QkNo1FWTFJjI6Ks0Xues8/m+32txrsNOQg+Bv a66Xc/kinSD3pE+rbizKUzhOxiKTr31YABJo4uE5PK4MZNXgDwAF9TJdPfkY501N32BH e01byKuFeqsoemwlgq01+DZd9N0utkodBFZrhQGucUhKgzjOogc1OQpOetgLMwWbpjvI W1t5KHu1WdfS/Eaj9G5uyDawrVdU7Dyq7WqYYbiFnMWPEjVfO8O+3SgiCmz2MjwluSGH IYoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umich.edu header.s=google-2016-06-03 header.b=GRmXrXfM; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umich.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d8si2027838edq.328.2020.04.28.11.15.10; Tue, 28 Apr 2020 11:15:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@umich.edu header.s=google-2016-06-03 header.b=GRmXrXfM; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umich.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728449AbgD1SPG (ORCPT + 99 others); Tue, 28 Apr 2020 14:15:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727827AbgD1SPG (ORCPT ); Tue, 28 Apr 2020 14:15:06 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EBA9C03C1AB for ; Tue, 28 Apr 2020 11:15:06 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id gr25so17998942ejb.10 for ; Tue, 28 Apr 2020 11:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; h=mime-version:from:date:message-id:subject:to; bh=pxjdZpqcamLG72XCoSC0lwx2EPV6FSiZswEBQmaksJg=; b=GRmXrXfMu0aHrweJmDldoLQs1l6BsdP3epaYKYbDr1apHyfPDV6ewbDRofsJxJGPaf DwdG33LsZ+GANlxzOfJ0p+jpe9Eq/ut//28m/7YSipMSw4pd2oRoTLrh/6Bk0nSYM+U8 9ESHNGeZdTs1W06PMgnB3DCxhIAeUkYryCqYIO1kyM3MCjWeccGJvMEI6gxCHA2YMTnx jEOwyR6Sb/0e9+3dd6FPLQkpX4o6wEQGCwR3NPA13zjogEAbApw7Q3DcKrfbNzNC75Hu yfT4HwPF+kmeN8CoVVZSogN9IK0ZzoZVaAdLWYW8mjo9FBBQAvsAJJAW7Z/uPsrcsgSl lPLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=pxjdZpqcamLG72XCoSC0lwx2EPV6FSiZswEBQmaksJg=; b=cTeaZRHUXnk49me0S3LXPUlyDWxUFOXZYhGEjUb486fDjYY/Sbe/pAQIOTo9/3wnFq zXv84/MirlCZvlV0Di7I0vSt6XH46N/dEbD24KK9eLpkan8OQB3+eeL5UgLh1HdmQfgx HnyP9mY2m9eWXvWeVGrEaKWMR2fDID0tW+p8VB+cYT5F2unLvnfJiH07s4E6xjM0gjno hJFjS9++vFxWv9usVl1+XCPrpzquqa2FMlvPE65zOk/aHGa/MKEfOwlwYtyj4SLMx5ls B4odbZZ7PrGe+JtpGtHot8GhVTWAywCjxVi4IGlbVqJtDlGZGvWrYXV8L5piOrb4p8Q5 whSw== X-Gm-Message-State: AGi0PuYfOrhCDDX4vpZeSzZCfYfuY2/O5vHGSGMIWan5xLSeX5Hxvt2Z ON1LetT/uGno0ykphqS/itYSlgMyLm3WvDGRfBbtlA== X-Received: by 2002:a17:906:54cd:: with SMTP id c13mr24914880ejp.307.1588097704563; Tue, 28 Apr 2020 11:15:04 -0700 (PDT) MIME-Version: 1.0 From: Olga Kornievskaia Date: Tue, 28 Apr 2020 14:14:53 -0400 Message-ID: Subject: handling ERR_SERVERFAULT on RESTOREFH To: linux-nfs Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi folk, Looking for guidance on what folks think. A client is sending a LINK operation to the server. This compound after the LINK has RESTOREFH and GETATTR. Server returns SERVER_FAULT to on RESTOREFH. But LINK is done successfully. Client still fails the system call with EIO. We have a hardline and "ln" saying hardlink failed. Should the client not fail the system call in this case? The fact that we couldn't get up-to-date attributes don't seem like the reason to fail the system call? Thank you.