Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4445571ybz; Tue, 28 Apr 2020 11:25:38 -0700 (PDT) X-Google-Smtp-Source: APiQypIoVmf97Nx3YR0CytTIb8gcj2iogjLeGCAM3FZs87QdYzWtfqzwMaZfkiSfhDCOgK/e4Jh6 X-Received: by 2002:aa7:c5cf:: with SMTP id h15mr24522394eds.213.1588098338686; Tue, 28 Apr 2020 11:25:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588098338; cv=none; d=google.com; s=arc-20160816; b=dNXCB8BHzbAtRXn0a6YREJrXJ4HbeyU4coxMxtVfYxtzdV0bt2E9cmbED3a4deRJid MWGtY+fhNbeshAGAVrUhpTfcVukO57i20f57GN7Vx1uhzZXJ9BaSbeW4M8726jy7ZtCV HMYxur+iW4hIIF6RF6OTwLOIT6kkhl1yudvnggkPpkAfxsd6qqHqS+kpf9vlAOgudDhr PW9K+EvG3f1KzwmRlfWr1Fi+EFD6FJOIzDVXlbFmIjvsCN+StXU0v5h4wQp/VziMVLyN 8777lHxJRXexNAUA8ogaE1DuC9WH+pY7qRBJPm+gUrgPbSDZLPzTo3Vwo7rV2qdH4dB2 TDBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=nnMiXqFOK/q/Db8uQpke53LKPToABJ5/fHBLiWyIV+A=; b=hztpWCq3v4yKiEGDJ7oLC7P3EZVHxG859llFdT0nHdavM2HREP4aDkSGTaF7PlVdH0 VYvBdLPlsPMKrWYlZ8pgYnmHE8nz82HGYIAvVMecgcqPl8x2AM1Alq884mJbb43FqdUb 0rVaKPqEr9UY7CQKS0wbvEJV8AkFMsCuqOuFK7S165MHHH5o/m7DKnQMZwZWA4SQ5tTu zX7J7/7zHbPjDO1wj+lKW2LNXdpU366wANU8PTFKE8CRqon7YTS02fT03oc4WNoo/cU1 MMZGdSfKxcqJwZ65n2oPYljiZaJwOVdCX3b/s+Gjo0PKoU1xt/gYXSc9Egez75992R8H j9IA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umich.edu header.s=google-2016-06-03 header.b=oaBhCBnb; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umich.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o17si2200415edv.44.2020.04.28.11.25.12; Tue, 28 Apr 2020 11:25:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@umich.edu header.s=google-2016-06-03 header.b=oaBhCBnb; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umich.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728392AbgD1SYz (ORCPT + 99 others); Tue, 28 Apr 2020 14:24:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727827AbgD1SYz (ORCPT ); Tue, 28 Apr 2020 14:24:55 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD0C0C03C1AB for ; Tue, 28 Apr 2020 11:24:54 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id n17so18020255ejh.7 for ; Tue, 28 Apr 2020 11:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=nnMiXqFOK/q/Db8uQpke53LKPToABJ5/fHBLiWyIV+A=; b=oaBhCBnbBCGXy59M8H1IhoSZ8cNXgHCWs1dcWzGilgRbolmeXxuQGffrWWufOmEcGr lHH8fy2y419klDAN856d1hZg20z7KIceam/zeMDotqmnrj8SirGDe0Xad3VVPjzJv6aB 3/GY56p7mgihaN+dsky3BOjMip/8aD9PoFr5ypkU6K6hq3XOPUpkW2X/cDBXJcU0yGZ1 7xyVTR59exAiqcAbIegRwHScm3MCnuzNExwwZeSg0jrBENXc9LX14JDsytZCqxwc5BrK Yy3eT3djw5FOSDTaXUjuKhoKU4QOhUHsz/TYS7lieEdLQu+LYxm/i2JUh9R+ymLU9UXa jpHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=nnMiXqFOK/q/Db8uQpke53LKPToABJ5/fHBLiWyIV+A=; b=ojuisEuZYjBNe32xf9NXoVhGeE6IjWByzppsIPZYhOuHLobq+Gdr2tYo/RFhzpr2Wn 024I0YbJg7SgrxTfPgomdrcJqZspWzNYxuS7o3ZGvnVWLVXNruSp7meu3o2FBATlr4U/ WQiab03HLaduMi3CETLUQIPvm48vC5mOqbfoslx6X7GMV8Bt2r7ZMF/qQXWB4nfCXiWc v/o09SznWDqr4C8Tu0bixBxO2mX7b4Uf8dzocn8qAWBYceFYpLAMCRPeqdZsoC/EtfpA UhTZmNhMxmKn3tQO0Z9g7KlsJoflC19jG9X8fCcsmYdLLq7FSpFeMlABWFlNSozTUnzH QZCw== X-Gm-Message-State: AGi0Pua2Xg4ueGyxjlOUYIMO/sNfiaiG++gmsq516TSpReKffJnm0bTP hc3XE2akqL50uw00aopAmLkmjb6omjplt2JL8v61lw== X-Received: by 2002:a17:906:1dce:: with SMTP id v14mr13618659ejh.244.1588098291457; Tue, 28 Apr 2020 11:24:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Olga Kornievskaia Date: Tue, 28 Apr 2020 14:24:40 -0400 Message-ID: Subject: Re: handling ERR_SERVERFAULT on RESTOREFH To: linux-nfs Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Apr 28, 2020 at 2:14 PM Olga Kornievskaia wrote: > > Hi folk, > > Looking for guidance on what folks think. A client is sending a LINK > operation to the server. This compound after the LINK has RESTOREFH > and GETATTR. Server returns SERVER_FAULT to on RESTOREFH. But LINK is > done successfully. Client still fails the system call with EIO. We > have a hardline and "ln" saying hardlink failed. correction: have a hardlink. > Should the client not fail the system call in this case? The fact that > we couldn't get up-to-date attributes don't seem like the reason to > fail the system call? > > Thank you.