Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp2000204ybj; Wed, 6 May 2020 08:55:34 -0700 (PDT) X-Google-Smtp-Source: APiQypJzn7VWMgr9ymQUzlIjXcDDX2ExqZXbI7YojrsV7itQzzApUtvvYjLjfwVfjDbMlbqPpOZJ X-Received: by 2002:a50:c60c:: with SMTP id k12mr7536786edg.111.1588780533950; Wed, 06 May 2020 08:55:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588780533; cv=none; d=google.com; s=arc-20160816; b=RbJzTJ6poDTwDLKVnxWZijkRaZBlH3Sc0OHU6A2ztNU/5w70s0R7lEZ6prM3qsDkyD aoEwvUJWNdO5QWzx/8sQ5kC3cc8dKDRADGQGaB7WHg1bVUsf5ZYr5khVFgOAbwHV7ptm 45oAVWcLKvh+rmjgyxBu6wd1yDz1+aDR3mkmIrVJIAQrgnTsAjMvSZcDXEV+3ofFwkI0 plbyf8YAqLylShW0ospbNv7DPkJGjlRyTTZeldrK1Pc2BFhLLQWtag4UFsEfy5Hbbzvn 0fNK5naRU3s55gI5mEoxo/mV7/tZ6AUHXNCpOBQYP+smMF/m+g9sNyRWmKF4DA0xyxoB ZgJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=pDPHNXOH2DUuVV7ltwfgOgYKPde6ZHhz6Lrj9RhWQIs=; b=Mv0LgWOt6PiaBAlJF+hIS5ZlTZLvxzGROOqxKF8Iqc481jDtWcbqB6tQ+X81qz4GTC 60vwGI04n+7y1mtR82Fsem/YZ2b9H0LXUdS3qzE1teEZS8l3kbDxskxolvmncUeS4HSU rMaG5M3l+tHVGd7bCyhVf6bp+C1GQQ3RR3LjUl+P7WJ8+nqDbLocfjcSb8melm52feu9 ogxS7EZ5Iafe/qiBLoWxL7m1MBFkaJwz04skYHl6wW1qoTv4C3VlafQ1QHWoohJDKon6 jbAj8+cpfE8hd/35giyykJibM2+FXGfiVBfRH1Hkek5/1eXgZE8JVDfflN1iJX90qjxV wwBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si1501683ejc.110.2020.05.06.08.55.06; Wed, 06 May 2020 08:55:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729321AbgEFPyl (ORCPT + 99 others); Wed, 6 May 2020 11:54:41 -0400 Received: from fieldses.org ([173.255.197.46]:47730 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728991AbgEFPyl (ORCPT ); Wed, 6 May 2020 11:54:41 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 8876B1507; Wed, 6 May 2020 11:54:40 -0400 (EDT) Date: Wed, 6 May 2020 11:54:40 -0400 From: "J. Bruce Fields" To: Tejun Heo Cc: "J. Bruce Fields" , Linus Torvalds , "open list:NFS, SUNRPC, AND..." , Jeff Layton , David Howells , Shaohua Li , Oleg Nesterov , Linux Kernel Mailing List Subject: Re: [PATCH 0/4] allow multiple kthreadd's Message-ID: <20200506155440.GB21307@fieldses.org> References: <1588348912-24781-1-git-send-email-bfields@redhat.com> <20200501182154.GG5462@mtj.thefacebook.com> <20200505021514.GA43625@pick.fieldses.org> <20200505210118.GC27966@fieldses.org> <20200505210956.GA3350@mtj.thefacebook.com> <20200505212527.GA1265@fieldses.org> <20200506153658.GA21307@fieldses.org> <20200506153920.GB3350@mtj.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506153920.GB3350@mtj.thefacebook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, May 06, 2020 at 11:39:20AM -0400, Tejun Heo wrote: > Hello, Bruce. > > On Wed, May 06, 2020 at 11:36:58AM -0400, J. Bruce Fields wrote: > > On Tue, May 05, 2020 at 05:25:27PM -0400, J. Bruce Fields wrote: > > > On Tue, May 05, 2020 at 05:09:56PM -0400, Tejun Heo wrote: > > > > It's not the end of the world but a bit hacky. I wonder whether something > > > > like the following would work better for identifying worker type so that you > > > > can do sth like > > > > > > > > if (kthread_fn(current) == nfsd) > > > > return kthread_data(current); > > > > else > > > > return NULL; > > > > > > Yes, definitely more generic, looks good to me. > > > > This is what I'm testing with. > > > > If it's OK with you, could I add your Signed-off-by and take it through > > the nfsd tree? I'll have some other patches that will depend on it. > > Please feel free to use the code however you see fit. Given that it'll be > originating from you, my signed-off-by might not be the right tag. Something > like Original-patch-by should be good (nothing is fine too). OK, I'll do that, thanks! --b.