Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp941596ybk; Wed, 20 May 2020 16:24:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzshw8Ynvs2rSNzBfABspqiCzykTwN5VG5W+wXgK7KSc1/vuCnwpi4aF2wro778HtXWj2g1 X-Received: by 2002:a50:b586:: with SMTP id a6mr5445978ede.292.1590017084460; Wed, 20 May 2020 16:24:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590017084; cv=none; d=google.com; s=arc-20160816; b=PyHAoF3EkpVdSsBvE6LeZJZSOvuwxA+tVh3qIAJoabf/KX03SAbmq65aIp9HvLNudw RL9FNUObJgaRv61d5c9tfxszSEtWft/6sVApvUG1vaoigMo9A4Du92z+eR3AL/uwdFSP JEOrZl7913FnE80mG0r8dgz6Kk5kJsiOjTCwkMrwt3gAPOwn4bS4njU/jGZsrAEpmIdc BwJsJu9CfE//GllpsBV02oAAhaYdrdbm40azZah7k0f+/+y7zLEB3XoH4bNbLFfuDz0f Y2LfHulJlijxp7yEqRoHc8ymNe3K3ZM/rBkk3AoR0MFE5LIgkzVN7bQmRZysjgh+nmwW Z/wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=HSeOgSwBSkuGRB1Ybh5Wd6Zbm5UHUgugEYTF7QZ8k14=; b=TJCW4KEPeuXLWEPdVzMghFzEYc6T02xjFZxuwBKOoCewUIN5nWPnyiXQn13Tf/IBfl CYjXsKwCsz50JBpxKaB/tBHVaZk38akMznSJQ4QpU+/EQtoWp8+XXW7jAOYWQRiv00PR MREduUSZFVTmt6n64Rtn8CXBmKwnR2wUh0HMmJ1zcX1RMMsuBLLGgWKZGhguThL+rsUJ v0sT9ubgw8H7/Isvngm38jOd5uepG6DC3lsbgEcxj8R1z1GccUmdSIyzCGx+h9AoL9vq zhOBjiq7sq1Gx2B4XATJ2iB3TuOk1pq/vDX028CIbNFsbGhViL0eCqKBMvceT0G4LSvj a5vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si2037974edw.72.2020.05.20.16.24.14; Wed, 20 May 2020 16:24:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbgETXYD (ORCPT + 99 others); Wed, 20 May 2020 19:24:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728462AbgETXYD (ORCPT ); Wed, 20 May 2020 19:24:03 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CA3BC061A0E; Wed, 20 May 2020 16:24:03 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477:9e51:a893:b0fe:602a]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9CDFF12728305; Wed, 20 May 2020 16:23:58 -0700 (PDT) Date: Wed, 20 May 2020 16:23:55 -0700 (PDT) Message-Id: <20200520.162355.2212209708127373208.davem@davemloft.net> To: marcelo.leitner@gmail.com Cc: hch@lst.de, kuba@kernel.org, edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, vyasevich@gmail.com, nhorman@tuxdriver.com, jmaloy@redhat.com, ying.xue@windriver.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay From: David Miller In-Reply-To: <20200520231001.GU2491@localhost.localdomain> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 May 2020 16:23:59 -0700 (PDT) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Marcelo Ricardo Leitner Date: Wed, 20 May 2020 20:10:01 -0300 > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > API could be a bit more complete than that. The APIs are being designed based upon what in-tree users actually make use of. We can expand things later if necessary.