Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp950028ybk; Wed, 20 May 2020 16:39:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4AcxMc8CJ0CePLnNqujxn1TqxMVtbzdWD8hzBYGNped+lzNIHGODWSon8+bQn7cx0f5ra X-Received: by 2002:a17:907:43bf:: with SMTP id ok23mr1395721ejb.68.1590017991990; Wed, 20 May 2020 16:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590017991; cv=none; d=google.com; s=arc-20160816; b=EnvGZOrYsbXvi4rEy6z2qCHYtrvMC3b2J4YpEAkLgPUf9bXjch7zHPj6f8z2tWmTPz sdzuhj//Y2hYDtiNdTZZRug+qM3XUHFlaPvbGAn3DfNUnyyD1AZvw69pD4q6ZUPOVG9Z eZi/3gO5Cf8bpohu+1ILKuSTEFHpWNISvc152nLJjqnAwHspONf+Gt2vCR9hg0raNHxl mhv/pXEX+lTE/d5JDo0CpPQOIfGvwsxNiylLW4BNT0WbvU5wpNGiYcKeqPL8AdklPCTe rtMu+7ses5XAuHk3u4O94FkoiZuUSmFIM7RMHcQCFgoVW8Qb7jHHCAy+6QEFZFBhVIFa bShw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=usgVE9wGsTmR3Ul4KmzuJXmMmNEoxcCV+K4pKCDDnEw=; b=qvJhhXpkkTEZ62re1NVu4h7wkb7aPCb/h5iY5zDb/Hpd8NnM+36SibF2iy0QBUlYMG 1Azce8P63hpv2NaKaqAMPVnkRAo6iCy+uc9cIN+DKc9H57yHMPXEgxEvz3DhmZB1+GMr zXeyGO92tN0JM+KSKr5zwNed1qbL7CTdqMlegWdkrH7nkvmoUBO/UD6aUJMxV6AbeH1A vXKpL2hNpouyB8p7vLuE8Vw1diuBlFOhaxEXphYATxk4es90Y9IKvj1K6VXeptIKuAib SFRmv/oIZpr/hdFMqshnIqP4rPBUytYHmQ2CXnbX2RkIGtMvTboDhm8xGa0VUBMrXxqq uYdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FsipvN1G; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si2430776ejr.669.2020.05.20.16.39.20; Wed, 20 May 2020 16:39:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FsipvN1G; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726727AbgETXjT (ORCPT + 99 others); Wed, 20 May 2020 19:39:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbgETXjS (ORCPT ); Wed, 20 May 2020 19:39:18 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B934C061A0E; Wed, 20 May 2020 16:39:17 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id m44so4094210qtm.8; Wed, 20 May 2020 16:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=usgVE9wGsTmR3Ul4KmzuJXmMmNEoxcCV+K4pKCDDnEw=; b=FsipvN1GuGM9UbR7VsW4XkubLiUqC8Dqtu7L937s2qadx/bxbgPsMl9fWYiJlizujH c9qxkVWOxpVMlAT7nNkHzdOL6XRXbCOpar1C4DQC47Sws3swXaaqI9YAuQyLubSZ0OK0 rRko/wzRAKCkIy15w/nWQBRVBLwMvtGjJCE2gisIPTfPY2zdgnpj1FMzVNCnVI10QH79 YBAX7tezDRj2K0TOr70GJg9yP9kYgu14VxvOjzih8uvep1FVSB5EojcU0QtKwd0T+IdB hjRKTNxmgJ9liw0vUGr1peJpzaW/R/f+lsktCjxXTndLxOoBi3/frCJqvNi3QaPXR6GX kpaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=usgVE9wGsTmR3Ul4KmzuJXmMmNEoxcCV+K4pKCDDnEw=; b=NX+9uVe/yO0GL9KKvOXOHz5GefBwZRpFfy0UuHRq/9fs+d7Q54crmTq+eztKuFh4KV mrzbWrwiEF2044382M3G9Q8ipjtasHXxaTgrRfrg1RYxTHCm7fS2H2ArcoYXKnToO3dE Om5GFMxY/+u7KqgCb9kq2W2sZVymiitDmKy4DA3wEseC06UIt+1E1DK+wY4U3jydrwmv LXqXEbW0BXFdo6Bm0kQ6Ryvi6DPK/2qKTmhxkiPfs4/05L4icxx3gP9RTEARQkq0U2pn RQMMLV+aRGJoxOYKx6cq2unZSbgeV9mINAar97dF/XXoKCwgN0KU5W5FXpfdXXnNWSQd Y8fw== X-Gm-Message-State: AOAM530kitqhp7j8IZQRRpzIFXJBDZpaIJprNSrFUZrdCEHBVWeplmTB C59Pm4gBUHx/XTUg8i+HSa8= X-Received: by 2002:ac8:1af3:: with SMTP id h48mr7625941qtk.371.1590017956516; Wed, 20 May 2020 16:39:16 -0700 (PDT) Received: from localhost.localdomain ([168.181.48.225]) by smtp.gmail.com with ESMTPSA id z10sm3685208qtu.22.2020.05.20.16.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 16:39:15 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 43E1FC0DAC; Wed, 20 May 2020 20:39:13 -0300 (-03) Date: Wed, 20 May 2020 20:39:13 -0300 From: Marcelo Ricardo Leitner To: David Miller Cc: hch@lst.de, kuba@kernel.org, edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, vyasevich@gmail.com, nhorman@tuxdriver.com, jmaloy@redhat.com, ying.xue@windriver.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay Message-ID: <20200520233913.GV2491@localhost.localdomain> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520.162355.2212209708127373208.davem@davemloft.net> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary. Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks. The comment still applies, though. (re the duplication)