Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp731255ybm; Thu, 28 May 2020 13:43:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYqwqx1fWb/Vxd0zTYFWnBdH2irw/hjsofjjwFg8o0TA5Ny0ZF1oJT+6SeWfibivQd0/no X-Received: by 2002:a05:6402:17c7:: with SMTP id s7mr5211206edy.57.1590698632069; Thu, 28 May 2020 13:43:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590698632; cv=none; d=google.com; s=arc-20160816; b=kCq3SfGk0A4He4WjYVaXxXk+3sJ8PC1lWKXiE6BDTbqfLgkyicF+p+HXlBAIIwNyha ftaOorM27wtpzonSLKWgjanhWTM0ejny6hM9n6p2GBV/yIqYowpo7vYtb4OdHXZEjNwB wyiMxkJst1LixAmxn8aYYg+w4BADEdY7wF83uRD7CVZiMVMCmG9w10LRyM8bQdL2R01T Jo7eCc04NLZWMOTsXBZOnTdpwNizHY4l86JXuNdFe/KceQbYMBM9LNGNehaFRzqgW3RA WgJReD9QdjbZ0ygJqUgtZOZW5/Bnp+X0vRYxJybq1HlqYET3kHWlOuYTRWilxyNKqmxR BCWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:subject:message-id:date:from :mime-version:dkim-signature; bh=qjhbjX6cWObDwZo7rT4OHwMsXKizS2RujfmOEdv1Jag=; b=w1YWStbC67QzE/ATPVw9Kjh5AsPYpYQGep3usrM4hBGtlYuYUyBj8ancb9UegyImtd xgsjfs/RwWMU3PE6BBPnKYRrakWLVy0TIg13cl/hBmxGB0d6hjsrGhU6tuBtKenwl576 +XsiKorLSRr1BVJEFYkBH7F4k16BVDWPsObVZsOINRItyeljKM7yx4NWfIGr4hh2fpCp sLQfWEC36GSjmSZLtEhHeR+ZM2Kj5mw8qnQZrtMAd5xjZtlCsDS4oz+WvXB6go6e/oat EbYcML2Je/JEUKvAKlofFPVjXrf0I/jYj1vPU4/Qem6DYToifIRyieQVmdomehXoDseg SXgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umich.edu header.s=google-2016-06-03 header.b=pQjZXc1+; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umich.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt27si4433372edb.94.2020.05.28.13.43.18; Thu, 28 May 2020 13:43:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@umich.edu header.s=google-2016-06-03 header.b=pQjZXc1+; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umich.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407238AbgE1Um6 (ORCPT + 99 others); Thu, 28 May 2020 16:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407321AbgE1Um4 (ORCPT ); Thu, 28 May 2020 16:42:56 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A469C08C5C6 for ; Thu, 28 May 2020 13:42:56 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a2so1375533ejb.10 for ; Thu, 28 May 2020 13:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; h=mime-version:from:date:message-id:subject:to; bh=qjhbjX6cWObDwZo7rT4OHwMsXKizS2RujfmOEdv1Jag=; b=pQjZXc1+1NvpngzhuSY9mxDudVDUapOS5zw/X2Rg94KNzrqhdyEJ9LOW13mkm5pmys Hf4ltnkyMguR9IUpZ8jbi3JvMyrx9/HFdCg0feBhiRHsPcXrxCzYfrjzWTebN0kRxNk8 vfcZtmLCF2yWx/pp72/Q3J8EjjB5elx/BWmUKS940WU267SmhxRR/HtpT27OLkpGq7k7 P9B1HZjR/jPhECb1TG7vigaRvPbvQZDpdfn6TAYwuukc95CQakIdDUQ+ykwxpG7cJvsy OX/gTF+MMpJVoIiX9rWjC3SPYmYsrc6JlAUuH5y6jw3GyEmmy/P8VTPRF8Jfp6C8wQdo 32tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qjhbjX6cWObDwZo7rT4OHwMsXKizS2RujfmOEdv1Jag=; b=tQ9PAf8WxlaERA6w2ZsgVrAX4Zooxi7yCo2EtOooGWE4yO1G1ox4LKreG5YsbqOcdg QjhAcj5TzpgKHcUN4mgga+j6IIp/Gk5xHMsinC1AKHu83iphrCCqItd648aCFqfqCgb9 Y6YQhbopvhhyP9eZ5QrMHgL+jMRVw4chJlJpvAmycvJDE9fjUh6dLREjRQPpmSabRPa2 9dyDVZbg/zG3U9gBMrjSbVG2QhyI+h8LNfSq+6BhzPcliBs5STK3Ukd4l4NF2MHy5imu +TncMnbGxIl5xoQ3bmhwwFQEfNDwwBA/CT7miTt+fVxAX9+nKH1SiHT2kR6krZTkp4Wo wH0g== X-Gm-Message-State: AOAM531g5Rs2BsFoR9o7uZFPTUsQCgcAoHglMKJEqZngUwPrMY/N8rRj 8/taUUJuRGGbwGaroTRDXsOAbxds8It/mjnJf7B/4g== X-Received: by 2002:a17:906:3454:: with SMTP id d20mr4559450ejb.451.1590698573845; Thu, 28 May 2020 13:42:53 -0700 (PDT) MIME-Version: 1.0 From: Olga Kornievskaia Date: Thu, 28 May 2020 16:42:42 -0400 Message-ID: Subject: How to handle revocation of locking state To: Trond Myklebust , linux-nfs Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi folks, Looking for recommendation on what the client is suppose to be doing in the following situation. Client opens a file and has a byte-range lock which returned a locking state. Client is acquiring another byte range lock. It uses the returned locking stated for the 2nd lock. Server returns ADMIN_REVOKED. Currently the client goes into an infinite loop of just resending the same LOCK operation with the same locking stateid. Is this a recoverable situation? The fact that the lock state was revoked, should it be an automatic EIO since previous lock is lost (so why bother going forward)? Or should the client retry the lock but send it with the open stateid? Thank you.