Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Subject: Re: [PATCH v2] mountstats: Adding 'Day:Hour:Min:Sec' format along
 with 'age' to "mountstats --nfs" for ease of understanding.
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <CAA_-hQLPDP208XriDoMBFEwnypPpEQJ_Tv5WSwDAbF_wW3fVFA@mail.gmail.com>
Date:   Thu, 4 Jun 2020 15:34:54 -0400
Cc:     Rohan Sable <rsable@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Steve Dickson <steved@redhat.com>, smayhew@redhat.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <3A17F2AE-CFCA-46B9-8779-060FCCB911AF@oracle.com>
References: <20200604175221.GA157967@fedora.rsable.com>
 <04942C45-9C31-424E-B5A1-C83553F786CE@oracle.com>
 <CAA_-hQKa6X1pqCoLkUjB+ApNxjWE3OapgxcSCL-B1b=npFefGQ@mail.gmail.com>
 <CAA_-hQLPDP208XriDoMBFEwnypPpEQJ_Tv5WSwDAbF_wW3fVFA@mail.gmail.com>
To:     Kenneth Dsouza <kdsouza@redhat.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Jun 4, 2020, at 3:23 PM, Kenneth Dsouza <kdsouza@redhat.com> wrote:
>=20
> I get the below results using the datetime module.
>=20
> # mountstats --nfs | grep -w age
>  NFS mount age: 688865; 7 days, 23:21:05

For pretty-printing the mount point's age, you probably don't need
to display the raw delta seconds value.


> On Fri, Jun 5, 2020 at 12:23 AM Kenneth Dsouza <kdsouza@redhat.com> =
wrote:
>>=20
>> Using the datetime module?
>>=20
>> datetime.timedelta(seconds =3D n)
>> Should print in below format
>> 0:11:05
>>=20
>> On Thu, Jun 4, 2020 at 11:45 PM Chuck Lever <chuck.lever@oracle.com> =
wrote:
>>>=20
>>>=20
>>>=20
>>>> On Jun 4, 2020, at 1:52 PM, Rohan Sable <rsable@redhat.com> wrote:
>>>>=20
>>>> This patch adds printing of 'Age' in 'Sec' and 'Day:Hours:Min:Sec' =
like below to --nfs in mountstats :
>>>> NFS mount age: 9479; 0 Day(s) 2 Hour(s) 37 Min(s) 59 Sec(s)
>>>>=20
>>>> Signed-off-by: Rohan Sable <rsable@redhat.com>
>>>> ---
>>>> tools/mountstats/mountstats.py | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>=20
>>>> diff --git a/tools/mountstats/mountstats.py =
b/tools/mountstats/mountstats.py
>>>> index d565385d..c4f4f9e6 100755
>>>> --- a/tools/mountstats/mountstats.py
>>>> +++ b/tools/mountstats/mountstats.py
>>>> @@ -233,6 +233,16 @@ Nfsv4ops =3D [
>>>>    'COPY_NOTIFY'
>>>> ]
>>>>=20
>>>> +# Function to convert sec from age to Day:Hours:Min:Sec.
>>>> +def sec_conv(rem):
>>>> +    day =3D int(rem / (24 * 3600))
>>>> +    rem %=3D (24 * 3600)
>>>> +    hrs =3D int(rem / 3600)
>>>> +    rem %=3D 3600
>>>> +    min =3D int(rem / 60)
>>>> +    sec =3D rem % 60
>>>> +    print(day, "Day(s)", hrs, "Hour(s)", min, "Min(s)", sec, =
"Sec(s)")
>>>> +
>>>=20
>>> Just wondering if there's a Python module that can do this for us?
>>>=20
>>>=20
>>>> class DeviceData:
>>>>    """DeviceData objects provide methods for parsing and displaying
>>>>    data for a single mount grabbed from /proc/self/mountstats
>>>> @@ -391,6 +401,8 @@ class DeviceData:
>>>>        """Pretty-print the NFS options
>>>>        """
>>>>        print('  NFS mount options: %s' % =
','.join(self.__nfs_data['mountoptions']))
>>>> +        print('  NFS mount age: %d' % self.__nfs_data['age'], =
end=3D"; ")
>>>> +        sec_conv(self.__nfs_data['age'])
>>>>        print('  NFS server capabilities: %s' % =
','.join(self.__nfs_data['servercapabilities']))
>>>>        if 'nfsv4flags' in self.__nfs_data:
>>>>            print('  NFSv4 capability flags: %s' % =
','.join(self.__nfs_data['nfsv4flags']))
>>>> --
>>>> 2.25.4
>>>>=20
>>>=20
>>> --
>>> Chuck Lever
>>>=20
>>>=20
>>>=20
>=20

--
Chuck Lever