Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [rpcbind 1/1] man/rpcbind: Mention systemd socket in -h
To:     Petr Vorel <pvorel@suse.cz>, linux-nfs@vger.kernel.org
References: <20200605075332.14564-1-pvorel@suse.cz>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <e3ad7d14-0535-f7fe-1ebe-2fda423c0c02@RedHat.com>
Date:   Tue, 9 Jun 2020 09:47:20 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200605075332.14564-1-pvorel@suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 6/5/20 3:53 AM, Petr Vorel wrote:
> and reformat doc a bit.
> 
> Based on Olaf Kirch's patch for openSUSE.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Committed... (tag: rpcbind-1_2_6-rc6)

steved.

> ---
> Hi Steve,
> 
> original patch:
> https://build.opensuse.org/package/view_file/openSUSE:Factory/rpcbind/0031-rpcbind-manpage.patch?expand=1
> 
> Olaf removed note about multi-homed host and about adding 127.0.0.1 an
> ::1. I kept them, but maybe multi-homed is not relevant any more or not
> limited only to UDP. Feel free to modify the text to better accommodate
> to current usage.
> 
> Kind regards,
> Petr
> 
>  man/rpcbind.8 | 32 ++++++++++++++++++++++----------
>  1 file changed, 22 insertions(+), 10 deletions(-)
> 
> diff --git a/man/rpcbind.8 b/man/rpcbind.8
> index af6200f..fbf0ace 100644
> --- a/man/rpcbind.8
> +++ b/man/rpcbind.8
> @@ -86,9 +86,16 @@ checks are shown in detail.
>  Do not fork and become a background process.
>  .It Fl h
>  Specify specific IP addresses to bind to for UDP requests.
> -This option
> -may be specified multiple times and is typically necessary when running
> -on a multi-homed host.
> +This option may be specified multiple times and can be used to
> +restrict the interfaces rpcbind will respond to.
> +When specifying IP addresses with
> +.Fl h ,
> +.Nm
> +will automatically add
> +.Li 127.0.0.1
> +and if IPv6 is enabled,
> +.Li ::1
> +to the list.
>  If no
>  .Fl h
>  option is specified,
> @@ -99,14 +106,19 @@ which could lead to problems on a multi-homed host due to
>  .Nm
>  returning a UDP packet from a different IP address than it was
>  sent to.
> -Note that when specifying IP addresses with
> -.Fl h ,
> +Note that when
>  .Nm
> -will automatically add
> -.Li 127.0.0.1
> -and if IPv6 is enabled,
> -.Li ::1
> -to the list.
> +is controlled via systemd's socket activation,
> +the
> +.Fl h
> +option is ignored. In this case, you need to edit
> +the
> +.Nm ListenStream
> +and
> +.Nm ListenDgram
> +definitions in
> +.Nm /usr/lib/systemd/system/rpcbind.socket
> +instead.
>  .It Fl i
>  .Dq Insecure
>  mode.
>