Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2068606ybt; Sun, 21 Jun 2020 08:11:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXRSmv7Zbv5z5PZ+eBPO94pHt5ElHfx9mW/IZZV+JmI4pJLDmWW4JaM2QybgWmynl5BIul X-Received: by 2002:a05:6402:1486:: with SMTP id e6mr12474306edv.99.1592752307289; Sun, 21 Jun 2020 08:11:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592752307; cv=none; d=google.com; s=arc-20160816; b=Fy2eeCEVRxDK0dYGHD366faxHsTDHq8jsCO/JPF3LUj7GND5LvvOxb7DrUrsIvmJJl oWcc7Lhq531Y/x4q4nIWFyPVjLQAb4tz+Myt3TwKdaaf0trA8NnGY26oEszArcd50acG 2JWJB4Alzcqd6bxK0cd6+hvTtS598zQbMshImGvqSW4CpaSJvCcROJNpHQJVBgssQ4ob 20eJlbqHU/FTildKEkuDk7fjvGrLW18KnCiLPu12i/VxKYb2FI4D9i0KiF3AgPCsKMdv w3G8HH+WF4u4A4PDsodEwTmA/e8TqW7I1l/w490LLpnF5uzwcwtuL98PSRGO06HRybex 7fUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=wlu5CSGF8CrDN81mFhVGaO3IVLDqpGhWNBGwGpsa/M4=; b=hXia7EGFMltaGD1n3QvKJpl1dwKx0J/h4kZ/RZHUXSvldN9JDpRMxAwX7IUGJhOVch h/X9XgrXdhOyKe3hUb08k4p5XuzjBhJSFNCywQwfqWmpPJYVeqSNLW79EvOuOP2zx35V 8GEYNdtCV6TH3XwJL8gtia8ZRjXKlxNp6JywF+rz3rVSu+5nc30yjUfszeXPssW7YniK olOUBKqSpcmtrLHJGpliOcYXdRd18XnmNQOoxfg2Nzo57glmC+eOgNwHWzv2bB9anJf4 GLUf9S0FD54xc6F0vhQUCs2Cy075I6srNd356V6gxse45DoH2zeW+QDWSoyRhp9wlav+ syEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernelim-com.20150623.gappssmtp.com header.s=20150623 header.b=Qj1e79Y3; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m22si7716651eds.604.2020.06.21.08.11.16; Sun, 21 Jun 2020 08:11:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernelim-com.20150623.gappssmtp.com header.s=20150623 header.b=Qj1e79Y3; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730248AbgFUPLP (ORCPT + 99 others); Sun, 21 Jun 2020 11:11:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730235AbgFUPLO (ORCPT ); Sun, 21 Jun 2020 11:11:14 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73339C061794 for ; Sun, 21 Jun 2020 08:11:14 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id a6so2872339wmm.0 for ; Sun, 21 Jun 2020 08:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelim-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wlu5CSGF8CrDN81mFhVGaO3IVLDqpGhWNBGwGpsa/M4=; b=Qj1e79Y3ru9wpHk0ukJCfQnDoAYKhRkEeGyq9Kn3g2b3ZgpRYn7p4Knlt2rfVMOnHt GjZX742CSXvD1f0wZDcErX61WLTCJNkQuAqxM86Uz3Zhi5t0C5FT9RAzeb0wgFYhvyKQ c0IZO08Z3SvP/sI/pkQcBSIBUDmu45KLcc6hKhbvnxW6A9zikTodd0QdAU7ATMzaymwa aSrkbPSuHCTe7kpRLQxLKiSOJ9GJ+gfqvmrLXci1UTM6187ob8zyO2cuRCqYIS6kDODO tC40VFnjaC3g/MpQ6VlfemRa0FvAaGArqpG5ROAXt3V8UC6ziKjW45H6MKyCsNefM4Si qW3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wlu5CSGF8CrDN81mFhVGaO3IVLDqpGhWNBGwGpsa/M4=; b=tFj0Vp9QkKyN8lAd8sGS4abQEPcdb/rIUDI4IGdKw4oHKiJwLovMpLbIsBVq4dze6x D4LNAg9bS+ljn6E+iwrOaLtGdu5CwS8XD4WBo4pnaPHXK/ZoiOds8xBmAgfUVlam65od j3McHzQaz/tv2TXFfAlIfEUbCMAan5jlKZXlp1uflPRimqqeLkbxsr17/WMg86U7Fjo5 rE7e21eIHzMhReoUTHopKCsdtKMuPBdTqxAXAYD9ZnCNztRNyZK/b1KQSxE59P1tJJmb sGfyFuNEYtUvrieE4DN83jdX4OVjEQZx9wSRJGcf7jro2FvEyWbZKKUgZx9p4eocRNHc XUtg== X-Gm-Message-State: AOAM532VUrvx58hSBeH7qiPd8bkZsssesFLNB033S8h9bddSbbOl2PEy J2B04ffSKVy7+ogJXKVq27mrig== X-Received: by 2002:a7b:c18f:: with SMTP id y15mr6161450wmi.85.1592752272155; Sun, 21 Jun 2020 08:11:12 -0700 (PDT) Received: from gmail.com ([141.226.9.235]) by smtp.gmail.com with ESMTPSA id 33sm7524335wri.16.2020.06.21.08.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 08:11:11 -0700 (PDT) Date: Sun, 21 Jun 2020 18:11:09 +0300 From: Dan Aloni To: Chuck Lever Cc: linux-rdma@vger.kernel.org, Linux NFS Mailing List Subject: Re: [PATCH] xprtrdma: Wake up re_connect_wait on disconnect Message-ID: <20200621151109.GA3006346@gmail.com> References: <20200620171805.1748399-1-dan@kernelim.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Sun, Jun 21, 2020 at 10:49:53AM -0400, Chuck Lever wrote: > >> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c > >> index 2ae348377806..8bd76a47a91f 100644 > >> --- a/net/sunrpc/xprtrdma/verbs.c > >> +++ b/net/sunrpc/xprtrdma/verbs.c > >> @@ -289,6 +289,7 @@ rpcrdma_cm_event_handler(struct rdma_cm_id *id, struct rdma_cm_event *event) > >> ep->re_connect_status = -ECONNABORTED; > >> disconnected: > >> xprt_force_disconnect(xprt); > >> + wake_up_all(&ep->re_connect_wait); > >> return rpcrdma_ep_destroy(ep); > >> default: > >> break; > > This hunk does not apply on top of fixes I've already sent to Anna for 5.8-rc1. > > So, if you don't object, I'll adjust your patch (this hunk and the description) > before sending it along to Anna. Sure, go ahead. Thanks for working on this! -- Dan Aloni