Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1994414ybh; Fri, 17 Jul 2020 06:55:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZ8TOojUel6payXRz2jJt7ANnhN4Aa0NROKUdlCmG3JP6r69aG48RDGV5G8NR04JBLrXWY X-Received: by 2002:a17:906:2799:: with SMTP id j25mr8636942ejc.466.1594994103414; Fri, 17 Jul 2020 06:55:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594994103; cv=none; d=google.com; s=arc-20160816; b=QuCm6RvCQbOj0ZkYDLznuvSUlmWJrA8mq6/9STWd2eSZGSqSak//Es2EK9DSSf23rQ R8YKhNm2fleX8I0ofm0BITZGqRpu/JKuLbg2baYyyNLK2VGytT4cN5p00mzOrQw0Uupq T1sEfNSV7DVUNiQO0BC3zk+KXYEojJr0FZuWPqKPZ10gdjDJVl6jEJsNC1FTWcq8JG/n okYOaSoqkhrwAf7wwcvXC4InOC/jCVV56BeudGZzlu2/uAokRQI7f/dlvGHxrAT8fsRe RFk6J9y5jc+IU2IgPpRH9J9tFh6VVXZBavcEDDwqrgufbnOq15/SoB7v0hwJWkE1EWH7 rfsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=bjFcpOUpRKawU2/RNUckL6N3Qmz0pABGT4OZrSSlCS8=; b=OtarRMEa4ks+b+Ne0ja9q4ZKpw0rEORjNhg9bfEgfhXJzxOxcRvR1Q8FZp3eDK67Cn vdhYMVQC5nx1rMzWX4wcQUb93qhM8tf19ETOk3iRocu6m+OPR7DBw5hlQQMWoRLfYaIR mAc3tfSLz0HnP7UhoItxDzsJG3nNqaI8HyTTmhi1Yg05w4L2fpKn601+ZCFSR0AhJhc9 CaJu2NjTyBEPRNBhhQnyPY36Wgmt6E6WSGL0cZg6vdTJMUVW6XVIf53IdtdOuiIL0A4r ky5Cu2kNUvA2qTahoz0SGH+Ev/H+Jki6oyICemnjpVEAGGbqo6AmWKXqwMxzPxi9dtO6 zwdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WlgSXkir; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mc27si5210786ejb.272.2020.07.17.06.54.33; Fri, 17 Jul 2020 06:55:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WlgSXkir; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbgGQNyQ (ORCPT + 99 others); Fri, 17 Jul 2020 09:54:16 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:26648 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726090AbgGQNyQ (ORCPT ); Fri, 17 Jul 2020 09:54:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594994056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjFcpOUpRKawU2/RNUckL6N3Qmz0pABGT4OZrSSlCS8=; b=WlgSXkirQ33AsctdsJRW15lOv1IzQ8xLdS8bnGQK9DVCr7ldn2oOqeVwRLaVDT66BuZOCL PwJHHMf44E/48vQjH2Iv6NkpRRmCogBuZ1vltoo9KAbd7nd2FI3LCpnXMGLPOJQa+mVxqp DSHin3GZ0NKr5M8JcjjFPHpmIJDLc3c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-kJv-pYbzPJuaAd314ZX8Cw-1; Fri, 17 Jul 2020 09:54:14 -0400 X-MC-Unique: kJv-pYbzPJuaAd314ZX8Cw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A65D9107ACCA for ; Fri, 17 Jul 2020 13:54:13 +0000 (UTC) Received: from madhat.boston.devel.redhat.com (ovpn-113-147.phx2.redhat.com [10.3.113.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6269561100; Fri, 17 Jul 2020 13:54:13 +0000 (UTC) Subject: Re: [nfs-utils PATCH 0/5] nfsdcld: Fix a number of Coverity Scan To: Scott Mayhew Cc: linux-nfs@vger.kernel.org References: <20200710203700.2546112-1-smayhew@redhat.com> From: Steve Dickson Message-ID: <16bf22bf-d308-4f78-236e-2c11844a9aa1@RedHat.com> Date: Fri, 17 Jul 2020 09:54:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200710203700.2546112-1-smayhew@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 7/10/20 4:36 PM, Scott Mayhew wrote: > These patches fix some errors in nfsdcld flagged by the Coverity scan > software. > > Scott Mayhew (5): > nfsdcld: Fix a few Coverity Scan RESOURCE_LEAK errors > nfsdcld: Fix a few Coverity Scan TOCTOU errors > nfsdcld: Fix a few Coverity Scan STRING_NULL errors > nfsdcld: Fix a few Coverity Scan CLANG_WARNING errors > nfsdcld: Fix a few Coverity Scan CHECKED_RETURN errors. > > utils/nfsdcld/legacy.c | 38 ++++++++++++-------------------------- > utils/nfsdcld/nfsdcld.c | 7 +++++-- > utils/nfsdcld/sqlite.c | 5 +++-- > 3 files changed, 20 insertions(+), 30 deletions(-) > Committed... (tag: nfs-utils-2-5-2-rc2) steved.