Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra
 whitespaces
To:     Salvatore Bonaccorso <carnil@debian.org>, linux-nfs@vger.kernel.org
Cc:     NeilBrown <neilb@suse.de>, Scott Mayhew <smayhew@redhat.com>
References: <20200628092441.81529-1-carnil@debian.org>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <c0223681-6ae1-a163-af54-bd560c11b571@RedHat.com>
Date:   Fri, 17 Jul 2020 09:55:55 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200628092441.81529-1-carnil@debian.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 6/28/20 5:24 AM, Salvatore Bonaccorso wrote:
> Although whitespaces immediately before or after the "=" are ignored,
> removing the extra whitespaces in some of the key=value assignments
> makes the style more consistent.
> 
> At least since systemd v242-rc1[1] this has been clarified that
> whitespaces immediately before and after the "=" are allowed.
> 
>  [1] https://github.com/systemd/systemd/commit/170342c90be07f418ab786718d95ef76289126a0
> 
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Committed... (tag: nfs-utils-2-5-2-rc2)

steved.
> ---
>  systemd/nfs-server.service | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> index 24118d693965..06c1adb71692 100644
> --- a/systemd/nfs-server.service
> +++ b/systemd/nfs-server.service
> @@ -1,18 +1,18 @@
>  [Unit]
>  Description=NFS server and services
>  DefaultDependencies=no
> -Requires= network.target proc-fs-nfsd.mount
> -Requires= nfs-mountd.service
> +Requires=network.target proc-fs-nfsd.mount
> +Requires=nfs-mountd.service
>  Wants=rpcbind.socket network-online.target
>  Wants=rpc-statd.service nfs-idmapd.service
>  Wants=rpc-statd-notify.service
>  Wants=nfsdcld.service
>  
> -After= network-online.target local-fs.target
> -After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> -After= nfs-idmapd.service rpc-statd.service
> -After= nfsdcld.service
> -Before= rpc-statd-notify.service
> +After=network-online.target local-fs.target
> +After=proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> +After=nfs-idmapd.service rpc-statd.service
> +After=nfsdcld.service
> +Before=rpc-statd-notify.service
>  
>  # GSS services dependencies and ordering
>  Wants=auth-rpcgss-module.service
>