Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Jul 2020 16:29:04 -0400
To:     Steve Dickson <SteveD@RedHat.com>
Cc:     Doug Nazar <nazard@nazar.ca>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: nfs-utils README updates
Message-ID: <20200717202904.GD21567@fieldses.org>
References: <34f07da7-250d-f354-bf59-74b9f1a0e16f@nazar.ca>
 <0555b3d1-8cbe-c3d8-2214-2bf7d3d65286@RedHat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0555b3d1-8cbe-c3d8-2214-2bf7d3d65286@RedHat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
From:   bfields@fieldses.org (J. Bruce Fields)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 17, 2020 at 01:34:03PM -0400, Steve Dickson wrote:
> Hey Doug,
> 
> On 7/16/20 5:36 PM, Doug Nazar wrote:
> > I was looking through the README to ensure my systems followed the correct setup and noticed a few things.
> > 
> > Looks like the reference to libnfsidmap can be dropped.
> > 
> > It looks like nfsdcld is again the correct setup for client tracking. A section should be added to SERVER STARTUP to include nfsdcld on NFS4+ servers.
> > 
> > Should it mention which modules are required before starting? I've had to locally add 'auth_rpcgss' to my startup scripts or svcgssd will bail on startup.
> > 
> > Any other changes or best practices that should be mentioned before I send a patch?
> 
> Yes... the README is dreadfully out of date... although most of it has
> not changed but a lot has... esp when it comes to the systemd set up..
> although the systemd/README is pretty accurate... Maybe a point to
> the systemd/README in the top README would be good. 
> 
> What script did you have to add 'auth_rpcgss' to? 
> It should be automatically  be loaded when the sunrpc 
> module is loaded.

Yes, looking at that out of curiosity... there's a request_module() in
net/sunrpc/auth.c that should be trying to load "rpc-auth-6".  Together
with the MODULE_ALIAS("rpc-auth-6") in net/sunrpc/auth_gss/auth_gss.c,
that should make this automatic.

--b.