Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] idmapd: Turn down the verbosity in flush_inotify()
To:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20200805190054.39513-1-steved@redhat.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <8d993f69-11d8-49f3-5146-02c1da8aae56@RedHat.com>
Date:   Fri, 7 Aug 2020 11:11:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200805190054.39513-1-steved@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 8/5/20 3:00 PM, Steve Dickson wrote:
> So idmapd does not flood the logs with messages
> nobody will understand, only print the message
> with verbose is set.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...

steved.
> ---
>  utils/idmapd/idmapd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
> index 8631414..7d1096d 100644
> --- a/utils/idmapd/idmapd.c
> +++ b/utils/idmapd/idmapd.c
> @@ -500,7 +500,8 @@ flush_inotify(int fd)
>  		     ptr += sizeof(struct inotify_event) + ev->len) {
>  
>  			ev = (const struct inotify_event *)ptr;
> -			xlog_warn("pipefs inotify: wd=%i, mask=0x%08x, len=%i, name=%s",
> +			if (verbose > 1)
> +				xlog_warn("pipefs inotify: wd=%i, mask=0x%08x, len=%i, name=%s",
>  				  ev->wd, ev->mask, ev->len, ev->len ? ev->name : "");
>  		}
>  	}
>