Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp494747pxa; Wed, 12 Aug 2020 07:13:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJzTvNw0pB5onaIIHY7ZMt64HamKqrc4j48EmOfGCfkmVouwYkdAixf3TChn9gD7t7JzBN X-Received: by 2002:a17:906:37d1:: with SMTP id o17mr30297ejc.98.1597241625706; Wed, 12 Aug 2020 07:13:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597241625; cv=none; d=google.com; s=arc-20160816; b=tiaJIgiqsft5hde4QaE9l6TM0b6iuzQ9n2kltjG6O+Y5ww6OldVU9gitsUBuGH5XYc fAMmo164+rtiksJLy/O2/oNJY1AH/Agsbm8rwkGAdpTuocfJYVFTPDS/fTjXgC23pX1E gyNjtsMlbk4kr3QlvZkdCOP2EQUu90sGOiytCYQXUVfeBdXG/tKDOmi3As4gckl4do5k cCQ5y/glLARp2dzxZO3yIiFJ8XA/li87qo9aD5h2D2Mp33Z05wlx5iJRdPDwABgc53LI DFWv60OGaMQT2lJNrRajGlkpQTvh+UfkmCqA4GtLSmxBrqFurxg0c2Ih9Liteoaitdto yNpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3JSWXdvJKypcewGZSL+FLA89GNbkLI8DDuSajPdeI90=; b=uomP4RPhuoNIzAtWpYFDTLQMGVci/Kh0phQz9EF/qfFw38S7c7pM+7VxZ1GpAnZ5N4 p3ZDQf/B0v8aJ3kwQIe+Z0xfQWy/kPu3LtJ397MX3kxIB5ZltnUj8YqvcL2d4kG6D+p9 fId2u0c0qqHeZlD5WZGBqbWTL9KQF5yo5+21TK205Pi69aDBMu7VHe04lgl3CdgwyF+O 0/tLEdG++cfegzv1iToFZJYJcdcudIo8dxKtYGm+2rB95aN6YTfSLc4/pi6I8dgwZyv8 xKdD2cnUfBP96LpQosPjEzyzD/GzfPigHQfa4JPwIxzxZsUhgOSnqqO9MycLNR9Eooz8 N6Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PDBU2thu; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bw6si1235794ejb.653.2020.08.12.07.13.12; Wed, 12 Aug 2020 07:13:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PDBU2thu; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbgHLONF (ORCPT + 99 others); Wed, 12 Aug 2020 10:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbgHLONF (ORCPT ); Wed, 12 Aug 2020 10:13:05 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4A03C061383; Wed, 12 Aug 2020 07:13:04 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id k20so2089012wmi.5; Wed, 12 Aug 2020 07:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3JSWXdvJKypcewGZSL+FLA89GNbkLI8DDuSajPdeI90=; b=PDBU2thuP7mGuehMwtGHU4dcvMwcHV2wHS5Fz6ERcv+PFycF9hHs89nJnf3Ro6X4LZ 8CKf3LZMB+B1OK5DFcChRayeL3G+pr2+Qdrfx9nHpNm79DF33ZPufWd5bl/7aDvNW2eA LdneA30b4Qb49jOsRpWSz3rMEhOJ52mRdIAIDorz6qjd2XSVXi4urt3HTbgPgtA0yP1a Ekdf2g1B1V4h7b7XuD7hH5nLZ0AbO+wuU79ppJxLJ/nDy3w5ooBKMvfhv1W2DirFwGDV QSKgMcUaVIhLhvRo5VID1PCfrFtTaOm9e0mRHnfQHwqjRBt0aAkIwWXJd2KyEglKw2rf VoSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3JSWXdvJKypcewGZSL+FLA89GNbkLI8DDuSajPdeI90=; b=mkrgBCyHgfMiw8E/kf+K7499ZVhLEToOkoqB6Vv2Ix0YQH0XlFw5tqx5xFBcfts8Dq Ploa2LQu6mNbhlj5RQi4SGNUCQSDXXVTAcKv0ZOhJKSrbIWvjWkX2X2IAfa5j84Da7o7 cUA/KeRvn8hl9M4LNGzDFwZDlIpSUnPlPSr13L1ZlYg5Yb15EvNcbuoTJAFuRddeHZah WGTgMYk01muZ3bEi1nvA82fMTWDrLOmc9dKEnvEwdpANC6Jl9CaGbItSB5NHwMRe6AK0 Dr7CIeNHNKB8T/NE9zmk1zP6vBPSFk/t0etgyP1N38R0xtIGMWmldDv9hKDh18S/bl/V gzFQ== X-Gm-Message-State: AOAM530lRqgHas/deQsXt62ivtvWsaJvncq+ZL/JvQgCzm1/v2td5VpE mBTmIUBwCEBQ87AAsNkwwJc= X-Received: by 2002:a1c:678b:: with SMTP id b133mr9401362wmc.117.1597241583696; Wed, 12 Aug 2020 07:13:03 -0700 (PDT) Received: from localhost.localdomain (cpc83647-brig20-2-0-cust926.3-3.cable.virginm.net. [82.19.195.159]) by smtp.gmail.com with ESMTPSA id g14sm3818331wmk.37.2020.08.12.07.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 07:13:02 -0700 (PDT) From: Alex Dewar To: "J. Bruce Fields" , Chuck Lever , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alex Dewar Subject: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c Date: Wed, 12 Aug 2020 15:12:51 +0100 Message-Id: <20200812141252.21059-1-alex.dewar90@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org In nfsd4_encode_listxattrs(), the variable p is assigned to at one point but this value is never used before p is reassigned. Fix this. Addresses-Coverity: ("Unused value") Signed-off-by: Alex Dewar --- fs/nfsd/nfs4xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 259d5ad0e3f47..1a0341fd80f9a 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -4859,7 +4859,7 @@ nfsd4_encode_listxattrs(struct nfsd4_compoundres *resp, __be32 nfserr, goto out; } - p = xdr_encode_opaque(p, sp, slen); + xdr_encode_opaque(p, sp, slen); xdrleft -= xdrlen; count++; -- 2.28.0