Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1356622pxk; Fri, 4 Sep 2020 07:30:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLpKTcWcAe30G7TJrXCw1a3L4aeJD5GYZZuXR1W84BvAMa0eCLb6KOPtY6okNow/eAJOng X-Received: by 2002:a17:907:9493:: with SMTP id dm19mr7636916ejc.268.1599229800315; Fri, 04 Sep 2020 07:30:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599229800; cv=none; d=google.com; s=arc-20160816; b=0am3h52epSi4Smq0OseqyicOk+/kGikl++IsVMWE8sdGqgnBwJYwNmXv9zHq0UWI0O sNZhS77KnWLEjLqNEy1RAHfgzwyc0I6dv4EbJzL/dMGTGrnpVCMxiEKO7BSdvIwuTZr7 GXZV7ESvB3ig+1naz/X4/mhBh83HvRBYIJg1PGwXvdAdnx2tcL1mmsWRQBdy/z3giLCN XgzSuH3DPD5JJwW3mwFX2F3i0fcwCsu6FE+oKQkqhwCXVjFsv+eKu1uLXl17OPdnHBxl x3Rbt0WWXoYcHMpmrM9iOPEfGbn/+c34uX0SrYgeJR9I6klGO7hPGkK4Pfvd/1cNA28u P70w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-filter; bh=dACq62FidyFRq/zUdggvXMM2CjkxwYUNeCEWUJxn/Wk=; b=S3p1BFHnyBWQ2L4mNIsLzbeBAwOOjmdtvlS0jbu6QeYQsl9nkkiXUcpdBSRK2EJ3nU CBapOtgR0ZYlwfoNpp116wsndy3JHy56P26Oao8UF63RC/PUxmO9A5C7UjcQe2xRmzMK 9gyHuucNcgCUV0NcD2MlUKh5DCvggXyjD973NsqLbBm/ErcDqygAdbXZkOrsq6diduhF /RJwXvTJX4XO7Xu3f2123pTnM95jTz74zAgZK6h1lkQMPrDNlk176R1udPkc36I/A+Ic K9ghEfAB5qUVpcWvkHeEn0/JYo435raaOW/Q8oLCbRLxDJT1kj+59oFwxXQUQMrla4Vv ofgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=qB37pzq6; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f10si4122763edy.472.2020.09.04.07.29.30; Fri, 04 Sep 2020 07:30:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=qB37pzq6; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730270AbgIDO32 (ORCPT + 99 others); Fri, 4 Sep 2020 10:29:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730266AbgIDO30 (ORCPT ); Fri, 4 Sep 2020 10:29:26 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2742C061244 for ; Fri, 4 Sep 2020 07:29:25 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 29A841509; Fri, 4 Sep 2020 10:29:23 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 29A841509 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1599229763; bh=dACq62FidyFRq/zUdggvXMM2CjkxwYUNeCEWUJxn/Wk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qB37pzq63wtA7j2JxFESjsTRtZYwJzSbGXJJ0/a6GzppIZPjmWkXl6oEj9rRlpSjA yj7TCXLaIXkqGz4FX4b7+TzcWqYD8p11N3/yf23YyK8Lq9WE5W3s46jCLrDj7EiKgu j/cC9rwD62IyJP7RemRWPA83czNrfoZUqXrO7cvI= Date: Fri, 4 Sep 2020 10:29:23 -0400 From: Bruce Fields To: Chuck Lever Cc: Anna Schumaker , Bruce Fields , Linux NFS Mailing List Subject: Re: [PATCH v4 2/5] NFSD: Add READ_PLUS data support Message-ID: <20200904142923.GE26706@fieldses.org> References: <20200828212521.GA33226@pick.fieldses.org> <20200828215627.GB33226@pick.fieldses.org> <20200901164938.GC12082@fieldses.org> <20200901191854.GD12082@fieldses.org> <20200904135259.GB26706@fieldses.org> <00931C34-6C86-46A2-A3B3-9727DA5E739E@oracle.com> <20200904140324.GC26706@fieldses.org> <164C37D9-8044-4CF4-99A1-5FB722A16B8E@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164C37D9-8044-4CF4-99A1-5FB722A16B8E@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, Sep 04, 2020 at 10:07:22AM -0400, Chuck Lever wrote: > My primary concern is that the result of a file copy operation should > look the same on NFS/TCP (with READ_PLUS) and NFS/RDMA (with SEEK_DATA/HOLE). I'm not sure what you mean. I don't see the spec providing any guarantee of consistency between READ_PLUS and SEEK. It also doesn't guarantee that the results tell you anything about how the file is actually stored--a returned "hole" could represent an unallocated segment, or a fully allocated segment that's filled with zeroes, or some combination. So, for example, if you implemented an optimized copy that used ALLOCATE, DEALLOCATE, SEEK and/or READ_PLUS to avoid reading and writing a lot of zeroes--there's no guarantee that the target file would end up allocated in the same way as the source. --b.