Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] rpc.idmapd: Do not free config varibles
To:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20200904181957.9772-1-steved@redhat.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <5ad5c795-66d3-bebc-6ae6-050d516047e6@RedHat.com>
Date:   Tue, 8 Sep 2020 11:27:27 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200904181957.9772-1-steved@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 9/4/20 2:19 PM, Steve Dickson wrote:
> Commit 93e8f092e added a conf_cleanup() call to clean
> up memory after the config file was parsed. It turns
> out that memory still needed and it is not very much
> so the call is removed.
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1873965
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... 

steved.
> ---
>  utils/idmapd/idmapd.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
> index f3d2314..51c71fb 100644
> --- a/utils/idmapd/idmapd.c
> +++ b/utils/idmapd/idmapd.c
> @@ -306,9 +306,6 @@ main(int argc, char **argv)
>  			serverstart = 0;
>  	}
>  
> -	/* Config memory is no longer needed */
> -	conf_cleanup();
> -
>  	while ((opt = getopt(argc, argv, GETOPTSTR)) != -1)
>  		switch (opt) {
>  		case 'v':
>