Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] NFSv4.2: fix client's attribute cache management for
 copy_file_range
Date:   Tue, 15 Sep 2020 18:19:41 +0000
From:   Frank van der Linden <fllinden@amazon.com>
To:     Olga Kornievskaia <olga.kornievskaia@gmail.com>
CC:     <trond.myklebust@hammerspace.com>, <anna.schumaker@netapp.com>,
        <linux-nfs@vger.kernel.org>, <jencce.kernel@gmail.com>
Message-ID: <20200915181932.GA27779@dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com>
References: <20200914202334.7536-1-olga.kornievskaia@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20200914202334.7536-1-olga.kornievskaia@gmail.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 14, 2020 at 04:23:34PM -0400, Olga Kornievskaia wrote:
> 
> 
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> After client is done with the COPY operation, it needs to invalidate
> its pagecache (as it did no reading or writing of the data locally)
> and it needs to invalidate it's attributes just like it would have
> for a read on the source file and write on the destination file.
> 
> Once the linux server started giving out read delegations to
> read+write opens, the destination file of the copy_file range
> started having delegations and not doing syncup on close of the
> file leading to xfstest failures for generic/430,431,432,433,565.
> 
> Reported-by: Murphy Zhou <jencce.kernel@gmail.com>
> Fixes: 2e72448b07dc ("NFS: Add COPY nfs operation")
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
>  fs/nfs/nfs42proc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
> index 142225f0af59..a9074f3366fa 100644
> --- a/fs/nfs/nfs42proc.c
> +++ b/fs/nfs/nfs42proc.c
> @@ -356,7 +356,11 @@ static ssize_t _nfs42_proc_copy(struct file *src,
> 
>         truncate_pagecache_range(dst_inode, pos_dst,
>                                  pos_dst + res->write_res.count);
> -
> +       NFS_I(dst_inode)->cache_validity |= (NFS_INO_REVAL_PAGECACHE |
> +                       NFS_INO_REVAL_FORCED | NFS_INO_INVALID_SIZE |
> +                       NFS_INO_INVALID_ATTR | NFS_INO_INVALID_DATA);
> +       NFS_I(src_inode)->cache_validity |= (NFS_INO_REVAL_PAGECACHE |
> +                       NFS_INO_REVAL_FORCED | NFS_INO_INVALID_ATIME);
>         status = res->write_res.count;
>  out:
>         if (args->sync)
> --
> 2.18.1

Should this be copied to stable@ ?

- Frank