Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Oct 2020 10:19:38 -0400
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     trix@redhat.com
Cc:     chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: remove unneeded break
Message-ID: <20201012141938.GC26571@fieldses.org>
References: <20201011155155.15538-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201011155155.15538-1-trix@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Sun, Oct 11, 2020 at 08:51:55AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Because every path through nfs4_find_file()'s
> switch does an explicit return, the break is not needed.

OK, applying.--b.

> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  fs/nfsd/nfs4state.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index c09a2a4281ec..741f64672d96 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
>  			return find_readable_file(s->sc_file);
>  		else
>  			return find_writeable_file(s->sc_file);
> -		break;
>  	}
>  
>  	return NULL;
> -- 
> 2.18.1