Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH] SUNRPC: fix copying of multiple pages in
 gss_read_proxy_verf()
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <8ed0fa80-cc75-88ec-6b17-3f9cc300e9bb@prodrive-technologies.com>
Date:   Wed, 21 Oct 2020 13:29:12 -0400
Cc:     Bruce Fields <bfields@fieldses.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Neil Brown <neilb@suse.de>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Roberto Bergantinos Corpas <rbergant@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D9B2DD62-E16C-4781-9EFD-FD8661642E24@oracle.com>
References: <20201019114229.52973-1-martijn.de.gouw@prodrive-technologies.com>
 <20201019152301.GC32403@fieldses.org>
 <834dc52b-34fc-fee5-0274-fdc8932040e6@prodrive-technologies.com>
 <20201019220439.GC6692@fieldses.org>
 <8ed0fa80-cc75-88ec-6b17-3f9cc300e9bb@prodrive-technologies.com>
To:     Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
Precedence: bulk


> On Oct 20, 2020, at 3:16 AM, Martijn de Gouw =
<martijn.de.gouw@prodrive-technologies.com> wrote:
>=20
> Hi,
>=20
> On 20-10-2020 00:04, J. Bruce Fields wrote:
>> On Mon, Oct 19, 2020 at 03:46:39PM +0000, Martijn de Gouw wrote:
>>> Hi
>>>=20
>>> On 19-10-2020 17:23, J. Bruce Fields wrote:
>>>> On Mon, Oct 19, 2020 at 01:42:27PM +0200, Martijn de Gouw wrote:
>>>>> When the passed token is longer than 4032 bytes, the remaining =
part
>>>>> of the token must be copied from the rqstp->rq_arg.pages. But the
>>>>> copy must make sure it happens in a consecutive way.
>>>>=20
>>>> Thanks.  Apologies, but I don't immediately see where the copy is
>>>> non-consecutive.  What exactly is the bug in the existing code?
>>>=20
>>> In the first memcpy 'length' bytes are copied from argv->iobase, but
>>> since the header is in front, this never fills the whole first page =
of
>>> in_token->pages.
>>>=20
>>> The memcpy in the loop copies the following bytes, but starts =
writing at
>>> the next page of in_token->pages. This leaves the last bytes of page =
0
>>> unwritten.
>>>=20
>>> Next to that, the remaining data is in page 0 of =
rqstp->rq_arg.pages,
>>> not page 1.
>>=20
>> Got it, thanks.  Looks like the culprit might be a patch from a year =
ago
>> from Chuck, 5866efa8cbfb "SUNRPC: Fix svcauth_gss_proxy_init()"?  At
>> least, that's the last major patch to touch this code.

It's likely that we didn't have a test scenario at bake-a-thon that
presents large tokens, so that new tail copy logic was never properly
exercised.


> I found this issue when setting up NFSv4 with Active Directory as KDC=20=

> and gssproxy. Users with many groups where not able to access the NFS=20=

> shares, while others could access them just fine. During debugging I=20=

> found that the token was not the same on both sides.
>=20
> I do not have the HW to setup a rdma version of NFSv4, so I'm unable =
to=20
> test if it still works via rdma.

You don't need special HW to get NFS/RDMA with Linux working, though.
Linux now has soft iWARP, and NFS/RDMA works fine with that.

As stated in the patch description for commit 5866efa8cbfb, the original
issue won't appear with Linux clients, because they use TCP to handle
the ACCEPT_SEC_CONTEXT handshake. You'd need to have both Solaris and
RDMA to test it. Maybe we can scrounge something up, but that would only
be enough to ensure that your patch doesn't regress the Solaris NFS/RDMA
with Kerberos setup when using small tokens.


--
Chuck Lever