Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1] mountstats: handle KeyError in display_raw_stats
To:     Rohan Sable <rsable@redhat.com>, linux-nfs@vger.kernel.org
References: <20201028125911.GA140323@fedora.rsable.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <d640308c-cc4d-ef25-4cac-5754051f82e8@RedHat.com>
Date:   Sat, 31 Oct 2020 12:16:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <20201028125911.GA140323@fedora.rsable.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/28/20 8:59 AM, Rohan Sable wrote:
> While printing Nfsv4ops from older /proc/self/mountstats
> e.g. in 2.6.32-754.el6.x86_64 from RHEL 6.10,
> it will not have all the Keys present leading to a KeyError
> like below :
> 
> Traceback (most recent call last):
>   File "nfs-utils/tools/mountstats/mountstats.py", line 1131, in <module>
>     res = main()
>   File "nfs-utils/tools/mountstats/mountstats.py", line 1120, in main
>     return args.func(args)
>   File "nfs-utils/tools/mountstats/mountstats.py", line 860, in mountstats_command
>     print_mountstats(stats, args.nfs_only, args.rpc_only, args.raw, args.xprt_only)
>   File "nfs-utils/tools/mountstats/mountstats.py", line 813, in print_mountstats
>     stats.display_raw_stats()
>   File "nfs-utils/tools/mountstats/mountstats.py", line 381, in display_raw_stats
>     print('\t%12s: %s' % (op, " ".join(str(x) for x in self.__rpc_data[op])))
> KeyError: 'FSID_PRESENT'
> 
> Signed-off-by: Rohan Sable <rsable@redhat.com>
I was not able to reproduce this on a RHEL6.10 box but it didn't make either. ;-) 

Committed... 

steved.
> ---
>  tools/mountstats/mountstats.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 25e92a19..23876fc4 100755
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -378,7 +378,10 @@ class DeviceData:
>                  print('\t%12s: %s' % (op, " ".join(str(x) for x in self.__rpc_data[op])))
>          elif vers == '4':
>              for op in Nfsv4ops:
> -                print('\t%12s: %s' % (op, " ".join(str(x) for x in self.__rpc_data[op])))
> +                try:
> +                    print('\t%12s: %s' % (op, " ".join(str(x) for x in self.__rpc_data[op])))
> +                except KeyError:
> +                    continue
>          else:
>              print('\tnot implemented for version %d' % vers)
>          print()
>