Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1505445pxb; Wed, 4 Nov 2020 10:42:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJznIZcUN/14o058RKnrUx79/74DHbDm85Xo+87qsk1QBz77q0eew2O+CiW01y1ydtiIqaax X-Received: by 2002:a17:906:2297:: with SMTP id p23mr65412eja.60.1604515359064; Wed, 04 Nov 2020 10:42:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604515359; cv=none; d=google.com; s=arc-20160816; b=Z7j/YWIWzCAlie2y0omwtaHSVzFeWCI05wbdEFeLUE90qlJ0XlvuxweiuaFZqj/j/u aJtbHxydmIYgdPyQuO+jD4riYOoJvgRrVx7OPjVg4GRK3otVNvoy/AtJr/hpnAc/cFMj A4xPiQa8HzX8coRLghUvd5MPJ4yrjYoKZTIlWIKz2pGainyjC5zuDxM9b82i79uU5fuM GOjVFnIZYV/JbZX/MFkYwyEzq7Y9YIo34pPVaBGQ4IurmjJTDmSdEOAIYHFrUCG9bRF9 cySQFB5r2pFjdkxaiwoyHaEZsiIl+yd1lyUaTIxo9Kz3ucD+NVCnj2hyhJa1DQYHvA4V x+JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=df2oz/ePqSi3umXPD40C0DyHZgA6UxXIkMnn1GF+38w=; b=IehdJVNGJINglKhaB5s6qPW1lHItQjfgVYqvy00FsblhgpnyQSLkxlerm89uc5eyfr IeSL+qCGwr3YRMVENaYCGeDAOp3iZqCaPy38ZwZpEvaOnlFR54VqhxNqd/iQwymekXrH v1DKqcy2iQtS9VhL5pg9HZueYg+AfCTxJrAZ2XWg32LKG+vuOtSRSsKZxEAOoax/PULp SLx/dJsvZmMp9ZO0mGkOcS8zpgc6Gt0YKHJHjbMmW4F1RsFRrQfYVGbfrm7Ub9hs5ZNU uWGiR58BKL4A1SzZBNLuILYj0VPtwTnANi7t7xA9Wnd7SxdFfisqjiG2FSZK/bp0J4y9 LHtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="U/Zeg0Az"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si1886811eju.299.2020.11.04.10.42.04; Wed, 04 Nov 2020 10:42:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="U/Zeg0Az"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731068AbgKDRTI (ORCPT + 99 others); Wed, 4 Nov 2020 12:19:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38820 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbgKDRTI (ORCPT ); Wed, 4 Nov 2020 12:19:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604510347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=df2oz/ePqSi3umXPD40C0DyHZgA6UxXIkMnn1GF+38w=; b=U/Zeg0AzOM1lYj+A5ZkFoMhzFy0E+36i/1dmB3MKO8LJtTPCBNKkNQqiwWCvNM5iqp1Qsk uOQKS5eaEXJ6yRb6n73F9LTOEmAV+Le7uBDbJvOeNeHgLao9d7d9jXLtCr3r6cCmtnQHSq /jo3cAwbWUOzFh+W7P9JO34QZDWtyEY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-ccHoukzbNWGLHjugq6mJjw-1; Wed, 04 Nov 2020 12:19:05 -0500 X-MC-Unique: ccHoukzbNWGLHjugq6mJjw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38F1A805EFD; Wed, 4 Nov 2020 17:19:04 +0000 (UTC) Received: from [172.16.176.1] (ovpn-64-2.rdu2.redhat.com [10.10.64.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F25041A3D6; Wed, 4 Nov 2020 17:19:03 +0000 (UTC) From: "Benjamin Coddington" To: "Trond Myklebust" Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 00/16] Readdir enhancements Date: Wed, 04 Nov 2020 12:19:02 -0500 Message-ID: <5C64BA42-DB89-4427-A3E9-FD4ED3BB1CF0@redhat.com> In-Reply-To: <50bf1f5c78d16d1018741febf822a00142a07b5b.camel@hammerspace.com> References: <20201103153329.531942-1-trondmy@kernel.org> <50bf1f5c78d16d1018741febf822a00142a07b5b.camel@hammerspace.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 4 Nov 2020, at 12:04, Trond Myklebust wrote: > Hi Ben > > Thanks for the review and the testing! Thank /you/ for the work! > You're right that I had screwed up the page access marking in the > previous patchsets. I believe this should be fixed in v3 by the > conversion to use grab_cache_page(), which calls find_or_create_page() > and should therefore do the right thing with the FGP_ACCESSED flag. > > I believe the reason why your patch above fails to fully correct the > issue is because we always want to mark the page as accessed if we've > scanned it. Ah, that make sense. I'll take the v3 for a ride tomorrow morning. Ben