Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1089353pxb; Fri, 6 Nov 2020 00:06:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTxZipFxrCxJkwX8SY4oTjM44ahIxoJ4+wGhCul/CLyEprZt7TVub4qet0rCSwU1Q7fzCr X-Received: by 2002:a17:906:4e41:: with SMTP id g1mr917766ejw.47.1604649979551; Fri, 06 Nov 2020 00:06:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604649979; cv=none; d=google.com; s=arc-20160816; b=DQRBiLEf46HKi8+E7YWjwuRmUvEQuUxu3c7zzubEXKpQw0YJ71/4w5tZMtx9HQi+7w qjErcTQWo8o5LkQLWoD+SrGj6Kypy15vHU/PY2ZKndTrvPXMGDCKHOkSDWxuHWqnnwYo FD7lOAqqdaxXsCNDD91Mfz7+qCaSAZUpO1GIS42aYOF6ShGg/8A2WvbAZMM17zxrc4ip hkWpJAdHfYSwQjGqDiQB4k+D/PBirue8FrZ8DZLkX5SesJPyHHhgk9Qz/H4ISWcFlI0b NL5NMU2bGX7Z08xg5Y8hZmDXxTdkolL+cP+zkeDLB+KqByz9K6frJ1ckrk8GU2qzAPO6 fq+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:references:cc:from:subject; bh=ul5C5PW1hl1TYX4xsrkcFQSFHVotIjhefo2XwuZrZOY=; b=KvWsHzq28xOR8cZwPc6OGASxYlDrAIEB9Ys0lf6WuIpP5fJYtuqQYc7wGWen2QIkql HeZh97O/nZYAGtuxFEFoLNpNxggK3UTpXtP7G4Uh6FVTAQHpYzEZd8Uoa2lj8G216bW9 v1AdHKi5BXb7ZuxEHmuYw/vMvcCR7qSH/QjDdN/rZgmYB1s1Sa36WJlkj0ViydB48VR2 WiAlgPdMtbFxXERK+4IR/f0LcQTSsf8tRJoZZI4Y/kwI9yb4hyMLTpW94t6dHPPZ34oe WZ619daHaEtoHnGVAJmHc+YaXhWR72qFSK/SekS6qP56J0k+QZH6+81cIBriQOB6iMTx Vxjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g20si398482ejm.505.2020.11.06.00.05.54; Fri, 06 Nov 2020 00:06:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbgKFIFm (ORCPT + 99 others); Fri, 6 Nov 2020 03:05:42 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:57230 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgKFIFm (ORCPT ); Fri, 6 Nov 2020 03:05:42 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UEPEc7J_1604649938; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UEPEc7J_1604649938) by smtp.aliyun-inc.com(127.0.0.1); Fri, 06 Nov 2020 16:05:39 +0800 Subject: Re: [PATCH] fs/nfsd: remove unused NFSDDBG_FACILITY to tame gcc From: Alex Shi Cc: "J. Bruce Fields" , Chuck Lever , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <1604634457-3954-1-git-send-email-alex.shi@linux.alibaba.com> <1604634457-3954-2-git-send-email-alex.shi@linux.alibaba.com> Message-ID: <8145bb50-8606-809d-01b2-221a6c259103@linux.alibaba.com> Date: Fri, 6 Nov 2020 16:05:28 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1604634457-3954-2-git-send-email-alex.shi@linux.alibaba.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Sorry, gcc is error on this case, it cann't find out much of NFSDDBG_##flag Forget this patch. Alex ?? 2020/11/6 ????11:47, Alex Shi ะด??: > There are lots of NFSDDBG_FACILITY defined in many files > but it isn't used anywhere. so remove it to tame the gcc warning: > > fs/nfsd/nfsxdr.c:12:0: warning: macro "NFSDDBG_FACILITY" is not used > [-Wunused-macros] > fs/nfsd/filecache.c:23:0: warning: macro "NFSDDBG_FACILITY" is not used > [-Wunused-macros] > fs/nfsd/nfs3xdr.c:17:0: warning: macro "NFSDDBG_FACILITY" is not used > [-Wunused-macros] > fs/nfsd/flexfilelayoutxdr.c:11:0: warning: macro "NFSDDBG_FACILITY" is > not used [-Wunused-macros] > fs/nfsd/nfsxdr.c:12:0: warning: macro "NFSDDBG_FACILITY" is not used > [-Wunused-macros] > fs/nfsd/filecache.c:23:0: warning: macro "NFSDDBG_FACILITY" is not used > [-Wunused-macros] > fs/nfsd/nfs3xdr.c:17:0: warning: macro "NFSDDBG_FACILITY" is not used > [-Wunused-macros] > fs/nfsd/flexfilelayoutxdr.c:11:0: warning: macro "NFSDDBG_FACILITY" is > not used [-Wunused-macros] >