Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2008623pxb; Sat, 7 Nov 2020 06:14:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxaRgWat/I8PcomQB9uLn4f2ZkOfv0u/u9Os9VXFD2J72Aq6Y3cvZUJnnrUFRgL0c0V+Nj3 X-Received: by 2002:a17:906:b53:: with SMTP id v19mr6773859ejg.136.1604758457131; Sat, 07 Nov 2020 06:14:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604758457; cv=none; d=google.com; s=arc-20160816; b=ECFKCOH+qPPObO3DIy0lGYduIN3Xv98lv2ktTHPU+2xyWXUreI8n0x9ooUMKBrY9Ld WcfA60iRJsWoC13NMsEgYFYqqTeXW6olztdGAhXWTUgV42IEXfXoWLl9lrHD21de9ciY 4GSgiy7/obRiLqdQVqtt4ruFhEndI7EAL5cDjmByQoy/e/HyfdtUSJrZxLHcaCIuCdxs jtjST3p8hys/8stumGjeRaZD8OR4WA2S0PkBchTC6L7zBXSvbVBpSk6OlM9lg+vJU8zz niyYOwFdFEfJd5N00e18MixCWPKzlnLJEZpPh6PnWnAsWi6S90iQYSXDLzhgLh+YgEkU LziQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=z4S6T/IRjlj+v8kkzHnVf9aVPqakQVAelVWhxJh31F8=; b=JcUfGDvnpJaROmUH0eIaJRRD13ONT3zEgAaGMOm/8pm2YvwCylwWsZmD5juJptq/YY rqMny8wHTdAyYmbgEezeU2kjWq1f6hSDcH6kmvK3WeB8p2Nd2pg9ILeYo7PLeDpZaZek BaftYffDZBxwpARiIjRXLKK03lVnDXLwVJYlYFC7mUeoGfO2JRausbTnZQmlF9GtUsA/ K7RIaOxeVGQ3ug+r11iXx+iygFMk4R20LlF7eEEL96TljDFiuvPjK4OB3GmwJiCwVVwC QV0eVOKwLX+upVnhcgf36aWa/EsvKeHbxr7zcRi4arSCfU5tNi6pQb3qvxbzUgCpWF16 ABVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I5USaNhu; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y12si3210649ejm.210.2020.11.07.06.13.40; Sat, 07 Nov 2020 06:14:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I5USaNhu; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbgKGONh (ORCPT + 99 others); Sat, 7 Nov 2020 09:13:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:58206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbgKGONg (ORCPT ); Sat, 7 Nov 2020 09:13:36 -0500 Received: from localhost.localdomain (c-68-36-133-222.hsd1.mi.comcast.net [68.36.133.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0C8E4206ED for ; Sat, 7 Nov 2020 14:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604758416; bh=/iBlu2K0xsO2o1VGNp4Tek/kyqit3aJSh9JjwIZHVTk=; h=From:To:Subject:Date:From; b=I5USaNhur1gkjRvt1vLUqZL0iL68fOgmJGdCgRfI6zkBLOhJBvwjPcsqArfH1S6/m jWE/HDC4z2itKXxbUWvIIso+jYpeiV6kBO9NZnGzwg/cr02AIEfrDrExoqYwP4+a3p pl6hLEgujOxSznzoS/TBrXv6FCQy2KBR9hxDFrJc= From: trondmy@kernel.org To: linux-nfs@vger.kernel.org Subject: [PATCH v4 00/21] Readdir enhancements Date: Sat, 7 Nov 2020 09:03:04 -0500 Message-Id: <20201107140325.281678-1-trondmy@kernel.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust The following patch series performs a number of cleanups on the readdir code. It also adds support for 1MB readdir RPC calls on-the-wire, and modifies the caching code to ensure that we cache the entire contents of that 1MB call (instead of discarding the data that doesn't fit into a single page). For filesystems that use ordered readdir cookie schemes (e.g. XFS), it optimises searching for cookies in the client's page cache by skipping over pages that contain cookie values that are not in the range we are searching for. Finally, it improves scalability when dealing with very large directories by turning off caching when those directories are changing, so as to avoid the need for a linear search on the client of the entire directory when looking for the first entry pointed to by the current file descriptor offset. v2: Fix the handling of the NFSv3/v4 directory verifier. v3: Optimise searching when the readdir cookies are seen to be ordered. v4: Optimise performance for large directories that are changing. Add in llseek dependency patches. Trond Myklebust (21): NFS: Remove unnecessary inode locking in nfs_llseek_dir() NFS: Remove unnecessary inode lock in nfs_fsync_dir() NFS: Ensure contents of struct nfs_open_dir_context are consistent NFS: Clean up readdir struct nfs_cache_array NFS: Clean up nfs_readdir_page_filler() NFS: Clean up directory array handling NFS: Don't discard readdir results NFS: Remove unnecessary kmap in nfs_readdir_xdr_to_array() NFS: Replace kmap() with kmap_atomic() in nfs_readdir_search_array() NFS: Simplify struct nfs_cache_array_entry NFS: Support larger readdir buffers NFS: More readdir cleanups NFS: nfs_do_filldir() does not return a value NFS: Reduce readdir stack usage NFS: Cleanup to remove nfs_readdir_descriptor_t typedef NFS: Allow the NFS generic code to pass in a verifier to readdir NFS: Handle NFS4ERR_NOT_SAME and NFSERR_BADCOOKIE from readdir calls NFS: Improve handling of directory verifiers NFS: Optimisations for monotonically increasing readdir cookies NFS: Reduce number of RPC calls when doing uncached readdir NFS: Do uncached readdir when we're seeking a cookie in an empty page cache fs/nfs/client.c | 4 +- fs/nfs/dir.c | 702 +++++++++++++++++++++++++--------------- fs/nfs/inode.c | 7 - fs/nfs/internal.h | 6 - fs/nfs/nfs3proc.c | 35 +- fs/nfs/nfs4proc.c | 40 +-- fs/nfs/proc.c | 18 +- include/linux/nfs_fs.h | 9 +- include/linux/nfs_xdr.h | 17 +- 9 files changed, 508 insertions(+), 330 deletions(-) -- 2.28.0