Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp205407pxu; Wed, 25 Nov 2020 00:29:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZN15zXmyq9fqtncnxh5K2tBCzFS4kYBcDJ1iB2sT8Gp3NgogGHHsOuK2Cl/k830yDzim/ X-Received: by 2002:aa7:d4da:: with SMTP id t26mr2388304edr.134.1606292957724; Wed, 25 Nov 2020 00:29:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606292957; cv=none; d=google.com; s=arc-20160816; b=eRO2LD6z/tLverg/EGDBwGTEY0uWUa0N5AviGhJV+9hJxYwa6835eY07zyeZpVdo7x JKSwY+t+CSWk4rrlE4CJHW/LN6SKEJveucSiK0reZ2GreBJIjfe4P9QHKsumGJMoE/Bp C4K9A4ga4MBq7QWbdhVI+/wiI/6em5RNLX2RwBQbygVmm/3nGDssKQCyzUzXAvpqOG5j pI+2corm3Cl01gM2+kZ7gObE10HEuI53ACbQ7Z8eOWa/9Ye0oxztRgXBcQdUdgiOy31T w74BFkw4ATyyP0A7YeIswdDu3mfwm72PjAZY0QCejvTKh5fziwbt6gvgC0F6WJliT8BF yjyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=RszexOezhRGzzfKKOU0gYUyO4rrxM/Pn9VDkhZSSEHQ=; b=LVOHP6aMIq1sqkbFuhR/QuP8lVopFjmLLCkE34Bp9X7f2RB3jeV0WDCowyQHHO9AU4 5RP1b7oUYhdyrxMADOVTl3E5j9TJxWMwA4376ar3o43k34fvS6Si6cnUeCmJwEkeqxkR jRi6mM5SEnqxUThAaFqhbE/kGoY8Im0bIBaE97+c10x5eQvM+9Sb5zAVvmRKmzn9VC5g XGuahMmlSYVRfxB+sPrsd0RnGrt0r2pQrAHF1+IZj1sU07YFBOSY3bsoYVvIN2r75iZB bwqfZeH+gArb0N5NsbNXxwuU9KlxOh2bqvageoazAA/TpIf8vmBoeAz6mjCT6uJDWny1 x6ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si778651edi.57.2020.11.25.00.28.39; Wed, 25 Nov 2020 00:29:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725875AbgKYI2h (ORCPT + 99 others); Wed, 25 Nov 2020 03:28:37 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:8583 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725287AbgKYI2h (ORCPT ); Wed, 25 Nov 2020 03:28:37 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CgvCm6WDTzLv7N; Wed, 25 Nov 2020 16:28:04 +0800 (CST) Received: from huawei.com (10.175.104.82) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Nov 2020 16:28:30 +0800 From: Huang Guobin To: , , , , , CC: , Subject: [PATCH] nfsd: Fix error return code in nfsd_file_cache_init() Date: Wed, 25 Nov 2020 03:39:33 -0500 Message-ID: <20201125083933.2386059-1-huangguobin4@huawei.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.82] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Fix to return PTR_ERR() error code from the error handling case instead of 0 in function nfsd_file_cache_init(), as done elsewhere in this function. Fixes: 65294c1f2c5e7("nfsd: add a new struct file caching facility to nfsd") Signed-off-by: Huang Guobin --- fs/nfsd/filecache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c index c8b9d2667ee6..a8a5b555f08b 100644 --- a/fs/nfsd/filecache.c +++ b/fs/nfsd/filecache.c @@ -686,6 +686,7 @@ nfsd_file_cache_init(void) pr_err("nfsd: unable to create fsnotify group: %ld\n", PTR_ERR(nfsd_file_fsnotify_group)); nfsd_file_fsnotify_group = NULL; + ret = PTR_ERR(nfsd_file_fsnotify_group); goto out_notifier; } -- 2.22.0