Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Nov 2020 13:47:53 +0100 (CET)
From:   "Mkrtchyan, Tigran" <tigran.mkrtchyan@desy.de>
To:     trondmy <trondmy@hammerspace.com>
Cc:     "J. Bruce Fields" <bfields@fieldses.org>, schumakeranna@gmail.com,
        linux-nfs <linux-nfs@vger.kernel.org>
Message-ID: <2007649768.3168809.1606308473907.JavaMail.zimbra@desy.de>
In-Reply-To: <245cbfff1a71061299d82afd216b355477919e59.camel@hammerspace.com>
References: <20201124135025.1097571-1-trondmy@kernel.org> <20201124161250.GA1091@fieldses.org> <20201124161809.GB1091@fieldses.org> <20201124202626.GA7173@fieldses.org> <245cbfff1a71061299d82afd216b355477919e59.camel@hammerspace.com>
Subject: Re: [PATCH v2 0/9] Fix various issues in the SUNRPC xdr code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: Fix various issues in the SUNRPC xdr code
Thread-Index: AQHWwmjfwELMdH++00y7mVYsFk0+kqnXdH0AgAABfYCAAEVeAIAAReoA3bguR4g=
Precedence: bulk

Just in case I did a mistake during bisecting I had re-done it and got agai=
n

c567552612ece787b178e3b147b5854ad422a836
Author: Anna Schumaker <Anna.Schumaker@Netapp.com>
Date:   Wed May 28 13:41:22 2014 -0400

    NFS: Add READ_PLUS data segment support

But change doesn't looks like it can break getdeviceinfo.

Tigran.

----- Original Message -----
> From: "trondmy" <trondmy@hammerspace.com>
> To: "J. Bruce Fields" <bfields@fieldses.org>
> Cc: schumakeranna@gmail.com, "linux-nfs" <linux-nfs@vger.kernel.org>
> Sent: Wednesday, 25 November, 2020 01:36:42
> Subject: Re: [PATCH v2 0/9] Fix various issues in the SUNRPC xdr code

> On Tue, 2020-11-24 at 15:26 -0500, J. Bruce Fields wrote:
>> On Tue, Nov 24, 2020 at 11:18:09AM -0500, J. Bruce Fields wrote:
>> > On Tue, Nov 24, 2020 at 11:12:50AM -0500, bfields wrote:
>> > > On Tue, Nov 24, 2020 at 08:50:16AM -0500,
>> > > trondmy@kernel.org=C2=A0wrote:
>> > > > From: Trond Myklebust <trond.myklebust@hammerspace.com>
>> > > >=20
>> > > > When looking at the issues raised by Tigran's testing of the
>> > > > NFS client
>> > > > updates, I noticed a couple of things in the generic SUNRPC xdr
>> > > > code
>> > > > that want to be fixed. This patch series replaces an earlier
>> > > > series that
>> > > > attempted to just fix the XDR padding in the NFS code.
>> > > >=20
>> > > > This series fixes up a number of issues w.r.t. bounds checking
>> > > > in the
>> > > > xdr_stream code. It corrects the behaviour of xdr_read_pages()
>> > > > for the
>> > > > case where the XDR object size is larger than the buffer page
>> > > > array
>> > > > length and simplifies the code.
>> > >=20
>> > > I'm seeing this on the client with recent upstream + these
>> > > patches.
>> >=20
>> > Unfortunately that was in the middle of a series of tests, and I'm
>> > not
>> > sure exactly what triggered it--I'm guessing cthon special over
>> > krb5i.
>> > I'll let you know what else I can figure out.
>>=20
>> Yeah, reproduceable by running cthon -s over krb5i, and it first
>> shows
>> up with the last patch, "NFSv4.2: Fix up read_plus() page alignment".
>=20
> OK, thanks! I'll just drop that one then. I don't think it really
> suffices to fix READ_PLUS as it stands.
>=20
>=20
> --
> Trond Myklebust
> Linux NFS client maintainer, Hammerspace
> trond.myklebust@hammerspace.com