Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH] nfsd: Fix error return code in nfsd_file_cache_init()
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20201125141758.GB2811@fieldses.org>
Date:   Wed, 25 Nov 2020 09:59:37 -0500
Cc:     Trond Myklebust <trond.myklebust@primarydata.com>,
        richard.sharpe@primarydata.com,
        Dros Adamson <dros@primarydata.com>,
        Jeff Layton <jeff.layton@primarydata.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <BFFAE931-5403-4790-8A2C-0E669FAEE292@oracle.com>
References: <20201125083933.2386059-1-huangguobin4@huawei.com>
 <20201125141758.GB2811@fieldses.org>
To:     Bruce Fields <bfields@fieldses.org>,
        Huang Guobin <huangguobin4@huawei.com>
Precedence: bulk


> On Nov 25, 2020, at 9:17 AM, J. Bruce Fields <bfields@fieldses.org> =
wrote:
>=20
> On Wed, Nov 25, 2020 at 03:39:33AM -0500, Huang Guobin wrote:
>> Fix to return PTR_ERR() error code from the error handling case =
instead of
>> 0 in function nfsd_file_cache_init(), as done elsewhere in this =
function.
>>=20
>> Fixes: 65294c1f2c5e7("nfsd: add a new struct file caching facility to =
nfsd")
>> Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
>> ---
>> fs/nfsd/filecache.c | 1 +
>> 1 file changed, 1 insertion(+)
>>=20
>> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
>> index c8b9d2667ee6..a8a5b555f08b 100644
>> --- a/fs/nfsd/filecache.c
>> +++ b/fs/nfsd/filecache.c
>> @@ -686,6 +686,7 @@ nfsd_file_cache_init(void)
>> 		pr_err("nfsd: unable to create fsnotify group: %ld\n",
>> 			PTR_ERR(nfsd_file_fsnotify_group));
>> 		nfsd_file_fsnotify_group =3D NULL;
>> +		ret =3D PTR_ERR(nfsd_file_fsnotify_group);
>=20
> I think you meant to add that one line earlier.
>=20
> Otherwise fine, but it looks like an unlikely case so can probably =
wait
> for the merge window.

Applied for the v5.11 merge window with Bruce's suggested change,
and pushed to the cel-next branch in

  git://git.linux-nfs.org/projects/cel/cel-2.6.git

or

  https://git.linux-nfs.org/?p=3Dcel/cel-2.6.git;a=3Dsummary


>> 		goto out_notifier;
>> 	}
>>=20
>> --=20
>> 2.22.0

--
Chuck Lever