Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp610427pxu; Thu, 3 Dec 2020 08:22:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxrg9n/z1HqlrS+5SwQ0By2+wckUEjjqY7ag+K/vogsa2fy/flrgljQXqu3Ryc0SNerkRjA X-Received: by 2002:a50:c2ca:: with SMTP id u10mr3638965edf.355.1607012557216; Thu, 03 Dec 2020 08:22:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607012557; cv=none; d=google.com; s=arc-20160816; b=E1ybpyNXp8iu6M1Wt//1SvRq/38j1bnZvyTn2aATmPoGfcz/L4+uMzfmnmYvtvnseZ NRDZwh5/djauR5ccGZ7bq2g14m+1wfkINGfHIGq474uXjuKjg/wNJor1gimCSIxuq3y5 1EfAStusuA/f27YKGzqPMLan7UWDLw61KeJc2WmK2nlkkttcyfEPcYTh391xVWVc5cHn ghP6DFPLTx1B/CyLa3RxmzhCGFj9+JhCs+wX0cpVuEcGoD+WXXfY05dWs/pIghYtk/hZ Jh5/3BEEGQriJSInRoh63ZjehwrFVHKAJq1k0ikJISRcx0GaWSznRT88u6mWkGeeNXx8 3yog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=HPjgKDHY3QoU63i+MwIL4oZhDpdGSvAZexj423632cE=; b=0DR+r2X2RL9rcwDfQ221fkUI4jt7auuOuRi9mvTv5AdDgwKZIR5r80H4tUqZQpAvQu 8UGrYSIB+yeOe/dsfcT9bhoNOK/E4ifCdmsw1MOX9xrh4Ye0ajJChw8rdTyonGaDACE+ wUos++dlGQs/Z9gVmo+16Vd3+Y9qnINTYTH/MWvJ/9JftEp2D72QsXIFlFBWGqm3tttP d9UCtCmYrMqXmYGNQEk2GJ8Y54LWRI0O/hZf8JlGEVvlPouRSwkmjNetGfmhbsk66MND ZQha2mlp/VUDhxL0AtEMPTOymvuGLbQHH2QO4L9SxVkMgsmWdtenUnSJywKYoStmsg7J s0oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=QRzmg5C6; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l22si1225388edt.34.2020.12.03.08.22.08; Thu, 03 Dec 2020 08:22:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=QRzmg5C6; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389336AbgLCQT6 (ORCPT + 99 others); Thu, 3 Dec 2020 11:19:58 -0500 Received: from smtp-fw-9101.amazon.com ([207.171.184.25]:4540 "EHLO smtp-fw-9101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389309AbgLCQT6 (ORCPT ); Thu, 3 Dec 2020 11:19:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1607012399; x=1638548399; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HPjgKDHY3QoU63i+MwIL4oZhDpdGSvAZexj423632cE=; b=QRzmg5C63r2bB8o1K/0zOn8xQ1VhbR7rvyyZO8JMxUdrqWbY+b60lufr ni0CKv5IGAotk0LffgOkA1DADwvOptOi6Et+FckU4Wt0BRbm5X42+tsdF BxWVl49neUM+5XKzLKWh9BbxlkZuWM6jJtmJFahujAnZtebML6OIaY/j6 Y=; X-IronPort-AV: E=Sophos;i="5.78,389,1599523200"; d="scan'208";a="93254237" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9101.sea19.amazon.com with ESMTP; 03 Dec 2020 16:19:03 +0000 Received: from EX13MTAUEB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com (Postfix) with ESMTPS id E85A9A2167; Thu, 3 Dec 2020 16:19:00 +0000 (UTC) Received: from EX13D01UEB004.ant.amazon.com (10.43.60.43) by EX13MTAUEB001.ant.amazon.com (10.43.60.96) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 3 Dec 2020 16:18:59 +0000 Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX13D01UEB004.ant.amazon.com (10.43.60.43) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 3 Dec 2020 16:18:59 +0000 Received: from dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com (172.23.141.97) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 3 Dec 2020 16:18:59 +0000 Received: by dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com (Postfix, from userid 6262777) id 141A8C1321; Thu, 3 Dec 2020 16:18:58 +0000 (UTC) Date: Thu, 3 Dec 2020 16:18:58 +0000 From: Frank van der Linden To: "Mkrtchyan, Tigran" CC: Olga Kornievskaia , linux-nfs , trondmy Subject: Re: Kernel OPS when using xattr Message-ID: <20201203161858.GA27349@dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com> References: <2137763922.1852883.1606983653611.JavaMail.zimbra@desy.de> <1296195278.2032485.1607010192169.JavaMail.zimbra@desy.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1296195278.2032485.1607010192169.JavaMail.zimbra@desy.de> User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Dec 03, 2020 at 04:43:12PM +0100, Mkrtchyan, Tigran wrote: > > Hi Olga, > > Franks patches are not applied. I will check with Trond's patch and > then will try those as well. > > Regards, > Tigran. Since my change no longer uses SPARSE_PAGES, it'll probably avoid the oops, so give it a try. Having said that, fixing SPARSE_PAGES seems like a better option.. My ideal outcome would be to have a working SPARSE_PAGES for all transports. That would allow GETXATTR and LISTXATTRS to just always specify a max size array of pages, giving it maximum flexibility to cache the received result no matter what, and avoiding allocations that are too large. For now, though, I'm happy with the v2 patch I sent in. - Frank