Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Dec 2020 17:38:12 +0100 (CET)
From:   "Mkrtchyan, Tigran" <tigran.mkrtchyan@desy.de>
To:     Frank van der Linden <fllinden@amazon.com>
Cc:     Olga Kornievskaia <aglo@umich.edu>,
        linux-nfs <linux-nfs@vger.kernel.org>,
        trondmy <trondmy@hammerspace.com>
Message-ID: <1661972531.2055379.1607013492207.JavaMail.zimbra@desy.de>
In-Reply-To: <1111804280.2055084.1607013367020.JavaMail.zimbra@desy.de>
References: <2137763922.1852883.1606983653611.JavaMail.zimbra@desy.de> <CAN-5tyEWYqXiqLdJE-DLH2b+LrVfPkviJDGQY=MyitS5aW4bJw@mail.gmail.com> <1296195278.2032485.1607010192169.JavaMail.zimbra@desy.de> <20201203161858.GA27349@dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com> <1111804280.2055084.1607013367020.JavaMail.zimbra@desy.de>
Subject: Re: Kernel OPS when using xattr
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: Kernel OPS when using xattr
Thread-Index: bDBSD7BRH6vvGSbCIoRzSwp4vkO7Z07vhu9k
Precedence: bulk

Oh. I tested V1.... Let me check v2 as well.

Tigran.

----- Original Message -----
> From: "Tigran Mkrtchyan" <tigran.mkrtchyan@desy.de>
> To: "Frank van der Linden" <fllinden@amazon.com>
> Cc: "Olga Kornievskaia" <aglo@umich.edu>, "linux-nfs" <linux-nfs@vger.kernel.org>, "trondmy" <trondmy@hammerspace.com>
> Sent: Thursday, 3 December, 2020 17:36:07
> Subject: Re: Kernel OPS when using xattr

> The patch from Frank works.
> ( you can attribute with Tested-by if needed)
> 
> Tigran.
> 
> ----- Original Message -----
>> From: "Frank van der Linden" <fllinden@amazon.com>
>> To: "Tigran Mkrtchyan" <tigran.mkrtchyan@desy.de>
>> Cc: "Olga Kornievskaia" <aglo@umich.edu>, "linux-nfs"
>> <linux-nfs@vger.kernel.org>, "trondmy" <trondmy@hammerspace.com>
>> Sent: Thursday, 3 December, 2020 17:18:58
>> Subject: Re: Kernel OPS when using xattr
> 
>> On Thu, Dec 03, 2020 at 04:43:12PM +0100, Mkrtchyan, Tigran wrote:
>>> 
>>> Hi Olga,
>>> 
>>> Franks patches are not applied. I will check with Trond's patch and
>>> then will try those as well.
>>> 
>>> Regards,
>>>    Tigran.
>> 
>> Since my change no longer uses SPARSE_PAGES, it'll probably avoid the
>> oops, so give it a try.
>> 
>> Having said that, fixing SPARSE_PAGES seems like a better option.. My
>> ideal outcome would be to have a working SPARSE_PAGES for all transports.
>> That would allow GETXATTR and LISTXATTRS to just always specify a max
>> size array of pages, giving it maximum flexibility to cache the received
>> result no matter what, and avoiding allocations that are too large.
>> 
>> For now, though, I'm happy with the v2 patch I sent in.
>> 
> > - Frank