Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] exportfs: Ingnore export failures in nfs-server.serivce
 unit
From:   Steve Dickson <SteveD@RedHat.com>
To:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20201210182452.20898-1-steved@redhat.com>
Message-ID: <5684bb05-d139-fabf-dc90-377d0a71c415@RedHat.com>
Date:   Fri, 11 Dec 2020 08:48:33 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20201210182452.20898-1-steved@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/10/20 1:24 PM, Steve Dickson wrote:
> With some recent commits, exportfs will continue on trying to
> export filesystems even when an entry is invalid or does
> not exist, but will still have a non-zero exit to report
> the error.
> 
> This situation should not stop the nfs-server service
> from comingup so nfs-server.service file should
> ignore these types of failures
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed. (tag: nfs-utils-2-5-3-rc2)

steved.
> ---
>  systemd/nfs-server.service | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> index 06c1adb..b432f91 100644
> --- a/systemd/nfs-server.service
> +++ b/systemd/nfs-server.service
> @@ -21,13 +21,13 @@ After=rpc-gssd.service gssproxy.service rpc-svcgssd.service
>  [Service]
>  Type=oneshot
>  RemainAfterExit=yes
> -ExecStartPre=/usr/sbin/exportfs -r
> +ExecStartPre=-/usr/sbin/exportfs -r
>  ExecStart=/usr/sbin/rpc.nfsd
>  ExecStop=/usr/sbin/rpc.nfsd 0
>  ExecStopPost=/usr/sbin/exportfs -au
>  ExecStopPost=/usr/sbin/exportfs -f
>  
> -ExecReload=/usr/sbin/exportfs -r
> +ExecReload=-/usr/sbin/exportfs -r
>  
>  [Install]
>  WantedBy=multi-user.target
>