Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 20 Dec 2020 21:46:19 -0500
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     Thomas Haynes <loghyr@gmail.com>
Cc:     Bruce Fields <bfields@redhat.com>,
        Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [pynfs 03/10] Close the file for SEQ10b
Message-ID: <20201221024619.GE24298@fieldses.org>
References: <20201217003516.75438-1-loghyr@hammerspace.com>
 <20201217003516.75438-4-loghyr@hammerspace.com>
 <20201218164325.GD1258@fieldses.org>
 <C99E0C08-FEC2-4F5A-9467-7B96CA8E51F2@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <C99E0C08-FEC2-4F5A-9467-7B96CA8E51F2@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Sun, Dec 20, 2020 at 06:42:55PM -0800, Thomas Haynes wrote:
> 
> 
> > On Dec 18, 2020, at 8:43 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
> > 
> > On Wed, Dec 16, 2020 at 04:35:09PM -0800, Tom Haynes wrote:
> >> 
> >>     close_file(sess1, fh, stateid=stateid)
> >> 
> >> +    # Cleanup
> >> +    res = sess1.compound([op.putfh(fh), op.close(0, stateid)])
> >> +    check(res)
> >> +
> > 
> > This is giving me:
> > 
> > SEQ10b   st_sequence.testReplayCache007                           : FAILURE
> >           OP_CLOSE should return NFS4_OK, instead got
> > 	              NFS4ERR_BAD_STATEID
> > 
> > probably because the file was already closed just above.  I'm not sure
> > whta was intended here.  Reverting for now.
> > 
> > —b
> 
> Ahh, that close is not there in the branch we have internally. And since git took the change, I thought it was still good.
> 
> Backing out is cool.

Oh, I see what happened, thanks for following up.

--b.