Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [pynfs 03/10] Close the file for SEQ10b
From:   Thomas Haynes <loghyr@gmail.com>
In-Reply-To: <20201218164325.GD1258@fieldses.org>
Date:   Sun, 20 Dec 2020 18:42:55 -0800
Cc:     Bruce Fields <bfields@redhat.com>,
        Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C99E0C08-FEC2-4F5A-9467-7B96CA8E51F2@gmail.com>
References: <20201217003516.75438-1-loghyr@hammerspace.com>
 <20201217003516.75438-4-loghyr@hammerspace.com>
 <20201218164325.GD1258@fieldses.org>
To:     "J. Bruce Fields" <bfields@fieldses.org>
Precedence: bulk


> On Dec 18, 2020, at 8:43 AM, J. Bruce Fields <bfields@fieldses.org> =
wrote:
>=20
> On Wed, Dec 16, 2020 at 04:35:09PM -0800, Tom Haynes wrote:
>>=20
>>     close_file(sess1, fh, stateid=3Dstateid)
>>=20
>> +    # Cleanup
>> +    res =3D sess1.compound([op.putfh(fh), op.close(0, stateid)])
>> +    check(res)
>> +
>=20
> This is giving me:
>=20
> SEQ10b   st_sequence.testReplayCache007                           : =
FAILURE
>           OP_CLOSE should return NFS4_OK, instead got
> 	              NFS4ERR_BAD_STATEID
>=20
> probably because the file was already closed just above.  I'm not sure
> whta was intended here.  Reverting for now.
>=20
> =E2=80=94b

Ahh, that close is not there in the branch we have internally. And since =
git took the change, I thought it was still good.

Backing out is cool.