Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 21 Dec 2020 15:00:11 -0500
To:     Tom Haynes <loghyr@gmail.com>
Cc:     Bruce Fields <bfields@redhat.com>,
        Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [pynfs python3 0/7] Python3 patches for st_flex.py
Message-ID: <20201221200011.GB27606@fieldses.org>
References: <20201219182948.83000-1-loghyr@hammerspace.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201219182948.83000-1-loghyr@hammerspace.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
From:   bfields@fieldses.org (J. Bruce Fields)
Precedence: bulk

On Sat, Dec 19, 2020 at 10:29:41AM -0800, Tom Haynes wrote:
> From: Tom Haynes <loghyr@excfb.com>
> 
> Hey Bruce,
> 
> This applies on top of the previous patch set.
> 
> This passes on my RHEL 8.2 client running python3 against a Hammerspace
> server.

Thanks, and thanks to Tigran for testing; applied.--b.

> 
> Thanks,
> Tom
> 
> fwiw - In some of the error paths, the system would complain that the
> exception StandardError was not defined.
> 
> I found this:
> https://portingguide.readthedocs.io/en/latest/exceptions.html#the-removed-standarderror
> 
> Tom Haynes (7):
>   CB_LAYOUTRECALL: Make string a byte array
>   st_flex: Use NFS4_MAXFILELEN in layout calls
>   st_flex: Provide an empty ff_layoutreturn4 by default for LAYOUTRETURN
>   st_flex: Use range instead of xrange for python3
>   st_flex: Test is now redundant
>   st_flex: Return the layout before closing the file
>   st_flex: testFlexLayoutStatsSmall needed loving to pass python3
> 
>  nfs4.1/nfs4client.py            |   2 +-
>  nfs4.1/server41tests/st_flex.py | 124 +++++++++++++++++---------------
>  2 files changed, 68 insertions(+), 58 deletions(-)
> 
> -- 
> 2.26.2