Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp9200086pxu; Mon, 28 Dec 2020 09:06:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJwlieZV9JpuZVXb/ET72O1Hgug96ykU1KvAJJgUdRJzGQ55CgwBDpZvdxOKRKVFUje0ECeW X-Received: by 2002:a17:906:1b46:: with SMTP id p6mr43690983ejg.68.1609175170102; Mon, 28 Dec 2020 09:06:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609175170; cv=none; d=google.com; s=arc-20160816; b=ySm0YV76AfP9qFdwJCnL5G/so1WT6jAZOnsaiPGMTSCKB9yEGdye1MOUKpXgE8POJf vAcrvUI/1b76rQLMp0Yj0e6/tQZzmhZDJOB9PDfD7lH5s87R9HdZtfVRmDSOgxVryKjC MLunT+W5Aci1pqWjv2Os5mfJzhgwrzpLh3nhL/AwlKWsk2RufciaXIXdZI+herrerLjp A45ouQUg+tocC62f7eq7iR/JD2KkUtybZbeC2OqwJtwfbvAn71qij03GihPiZNPPMZGR Kq6Cz3IYM45x0T2QrxCaWFb25vc9A6v/HhofsbKj6fG7nkeYQFmUTIRmudxUWSprEkXa 9SfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=3LlD+dScTbPaJ7b9z6fQ7/W16eGNy+ofmIXcLIypBE4=; b=LUTWEeRqTZJ0SN0ApNa06HqayJr+WFbaEoRWMdIr1IsYk2vf1vKOs1EHV/34/NLQnq QSG4o3P5roCgzaUSatPh7cld857To+tWWcMPmHE7l4ha6OLxTEbceWHnY/VJaWwEXuex +dQ1arLdL96CMPYaO6B7lPzQtmk1oCKdc8ntVqm8INiIG3xH/ziyyrSNFiSPhZuRMGFj wmkzZhg3hka6tE4Me3wdosPE/37EmALTfIvc55WbO9eKFk1f6QHTI0vlaiLueu5ygJJa OGCk+TGJn03ABeh3l52U5VOCtqp7UfVaWX9j51UYGglp0vmAfPZQ72hucvAN8nHLNFjf vf3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MqG+igwf; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si20748952eds.266.2020.12.28.09.05.45; Mon, 28 Dec 2020 09:06:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MqG+igwf; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbgL1REd (ORCPT + 99 others); Mon, 28 Dec 2020 12:04:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727912AbgL1REc (ORCPT ); Mon, 28 Dec 2020 12:04:32 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5370C0613D6 for ; Mon, 28 Dec 2020 09:03:51 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id u19so10353851edx.2 for ; Mon, 28 Dec 2020 09:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=3LlD+dScTbPaJ7b9z6fQ7/W16eGNy+ofmIXcLIypBE4=; b=MqG+igwfjYxnFkwXJnDAGnGyjl4gGZ6932hxWGR8X/C5QXvKhuj5MQxONF9lmPhriD j3POBtjILt3V8DzoPzcuZMzdknPcCKRl0vd+kYFszwJrYc0c3OcFbBezbyTWmnKmjNIC Wl/wcY2JsXpRxOIl4h6Ukpab3I8R5sEl7Aqlejih15wYC0OA3vEqZ3Mr8m9eDYezywVw rFLrJgZxN78C0BCBqT/4qXSOUUT7hm0srYDCI8hWR0nXvPnXNccLVlurw7o2NTuZ9Qgl ai6BKnGWH5eC/xXILMfzQR9+CLVC6NncTXAQpc3cg4WEuYo0Z8mh0opplkJ/joAKUXhx dvrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3LlD+dScTbPaJ7b9z6fQ7/W16eGNy+ofmIXcLIypBE4=; b=XZFOf5ovRUxAQwZfSZKbXSJTAUZocqlVTu8KHerQkwp4dmAWpbXFmurqscVK28Gs/C XcK7wf4f+PpWvgUePW6d8wjU6TDusDSzZOasX8p+4aiNRdwMmA+u9aRpbrJTIacyhr8p olnJEcY1gyGjVa+27ckLrv7JV048xzxDi/kd0SGduFlrdRCvptOcWjrQG7SuQku5lAGo hWnZSuXo3EeL5IpcLg6c5Fax46WGGYd/Sa2pJv9ZoaPpoGQx0p+i9HmMqaI1D/fV4hB2 sStgHX0DymZhuQV0q1XhRYC4QYQQYXTTeCnBD0e1YVEe0Xg8JFYuKNDkqDgwXZncRNgd e3Ew== X-Gm-Message-State: AOAM532AsDh3tkrQRLVU9JqM+EZpbB+hby0bmsgPVf28dENFVh67qo+g EqimpXpNgcdK/d8jqzBRxEQn3OhsL1M= X-Received: by 2002:aa7:c698:: with SMTP id n24mr42897159edq.277.1609175030630; Mon, 28 Dec 2020 09:03:50 -0800 (PST) Received: from localhost.localdomain ([31.210.181.203]) by smtp.gmail.com with ESMTPSA id i15sm17417082ejj.28.2020.12.28.09.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 09:03:50 -0800 (PST) From: Amir Goldstein To: "J . Bruce Fields" , Jeff Layton Cc: linux-nfs@vger.kernel.org Subject: [PATCH 0/2] Improvements to nfsd stats Date: Mon, 28 Dec 2020 19:03:42 +0200 Message-Id: <20201228170344.22867-1-amir73il@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Bruce, The original motivation for this work was to add per-export stats. While doing so, I noticed that most nfsd stats variables are not protected against concurrent update, so fixed that first. There are still a couple stats variables (longest_chain*) that are not counters so less trivial to fix. I did not touch them. There is also an eyebrow raising number of variabled in nfsd_stats struct that are never updated. I did not touch those either. If you want me to send a cleanup patch to remove them and print hardcoded zeroes in the nfsd stats file I can do that. Thanks, Amir. Amir Goldstein (2): nfsd: protect concurrent access to nfsd stats counters nfsd: report per-export stats fs/nfsd/export.c | 68 +++++++++++++++++++++++++++++++----- fs/nfsd/export.h | 17 +++++++++ fs/nfsd/netns.h | 20 +++++++---- fs/nfsd/nfs4proc.c | 2 +- fs/nfsd/nfscache.c | 52 +++++++++++++++++++-------- fs/nfsd/nfsctl.c | 8 ++++- fs/nfsd/nfsfh.c | 9 +++-- fs/nfsd/stats.c | 87 ++++++++++++++++++++++++++++++++++++---------- fs/nfsd/stats.h | 42 +++++++++++++++------- fs/nfsd/vfs.c | 6 ++-- 10 files changed, 243 insertions(+), 68 deletions(-) -- 2.17.1