Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [RFC PATCH 0/7] SUNRPC: Create sysfs files for changing IP
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20210111214143.553479-1-Anna.Schumaker@Netapp.com>
Date:   Tue, 12 Jan 2021 08:09:09 -0500
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Anna Schumaker <Anna.Schumaker@Netapp.com>
Content-Transfer-Encoding: 7bit
Message-Id: <CE510EA5-1E3F-4516-A948-10A0FF31C94F@oracle.com>
References: <20210111214143.553479-1-Anna.Schumaker@Netapp.com>
To:     Anna Schumaker <schumaker.anna@gmail.com>
Precedence: bulk

Hi Anna-

> On Jan 11, 2021, at 4:41 PM, schumaker.anna@gmail.com wrote:
> 
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
> 
> It's possible for an NFS server to go down but come back up with a
> different IP address. These patches provide a way for administrators to
> handle this issue by providing a new IP address for xprt sockets to
> connect to.
> 
> This is a first draft of the code, so any thoughts or suggestions would
> be greatly appreciated!

One implementation question, one future question.

Would /sys/kernel/net be a little better? or /sys/kernel/sunrpc ?

Do you have a plan to integrate support for fs_locations to probe
servers for alternate IP addresses? Would that be a userspace
utility that would plug values into this new /sys API?


> Anna
> 
> 
> Anna Schumaker (7):
>  net: Add a /sys/net directory to sysfs
>  sunrpc: Create a sunrpc directory under /sys/net/
>  sunrpc: Create a net/ subdirectory in the sunrpc sysfs
>  sunrpc: Create per-rpc_clnt sysfs kobjects
>  sunrpc: Create a per-rpc_clnt file for managing the IP address
>  sunrpc: Prepare xs_connect() for taking NULL tasks
>  sunrpc: Connect to a new IP address provided by the user
> 
> include/linux/sunrpc/clnt.h |   1 +
> include/net/sock.h          |   4 +
> net/socket.c                |   8 ++
> net/sunrpc/Makefile         |   2 +-
> net/sunrpc/clnt.c           |   5 ++
> net/sunrpc/sunrpc_syms.c    |   8 ++
> net/sunrpc/sysfs.c          | 160 ++++++++++++++++++++++++++++++++++++
> net/sunrpc/sysfs.h          |  22 +++++
> net/sunrpc/xprtsock.c       |   3 +-
> 9 files changed, 211 insertions(+), 2 deletions(-)
> create mode 100644 net/sunrpc/sysfs.c
> create mode 100644 net/sunrpc/sysfs.h
> 
> -- 
> 2.29.2
> 

--
Chuck Lever