Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp66711pxb; Wed, 20 Jan 2021 01:05:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8+a+W2SEeDUc8z8RxvLjBxfeexzJkKlIBLYqYEIWXtJzlfhk0M9dyDrQI/2O8uBj8uE15 X-Received: by 2002:a05:6402:1819:: with SMTP id g25mr6301025edy.46.1611133535505; Wed, 20 Jan 2021 01:05:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611133535; cv=none; d=google.com; s=arc-20160816; b=E6RKTJo85HRS2tmvckQcAYinKoL12ht/sIAWdbs/WX6c7BUoflVmwwdRSTBtVgnViJ fkkWZxIu/05O9pZuGeZYU4ITUKl19Q2n8/pk1IOTWl73e2wHIzpKEtKG1R9KVEbBxx1q gtwJG2MOeMPhOlw7tHHlxFbnE4dNFG+34ZxTkyY+rwPUsq6DvnfbW9j9vA9aMg5wdB92 QdCLKfrTrKPRpQ8Z2QnGtQphI2pydZ9wN40F6865ZIqi+IT6+cSf722vXCiIdTubjv+C 25oaNiIvAJYKt4TTDyUuVgCY8K7Zpo48yNYYlzVPtJ3gjjrAXXw7TyDGvFwngxSmk4cz GqCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RaWLb5cuOxioAYXgsdU/4k1ily/oqbSWtIgPbTftsvU=; b=EXCFXraKRes3rqUH2Mgt4Qhc7+RlXfEHzjabkxgrDEMwLwEemq1aFGfTNtKgcJR+lp j6iCJiFo/GCJQJAOnDcg6yv1k9d0yhImz5/0kRZ7wHV+/uhapxFfq1bei0cZHyVUHNdE t/vY+ZAMmAq811Nxh2tl/0pngVEhQ+c5wHVhnK/UOFeRB2SzGX4ZgynQYOyyOsEwfx0h PGMPkWw6Mt0L8dfv6stZuXoiR1jOnqGgSS2LS8YAQbMt83LFf1giMVnSDDEZCb2lMJ9Z qzRhRekFGzbmHH/tCpH9Jo5cJ3xXAjejePd0/CmcUHJa36XQVviwS76JT7nCmjJDEqMT JMjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="s/AYqCvK"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bw26si475716ejb.644.2021.01.20.01.04.58; Wed, 20 Jan 2021 01:05:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="s/AYqCvK"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728277AbhATJBh (ORCPT + 99 others); Wed, 20 Jan 2021 04:01:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728291AbhATJAk (ORCPT ); Wed, 20 Jan 2021 04:00:40 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2672C061575; Wed, 20 Jan 2021 00:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RaWLb5cuOxioAYXgsdU/4k1ily/oqbSWtIgPbTftsvU=; b=s/AYqCvKSMxlrqVI39kGzkvJ4D SOw3rkTBfb/Y6ft2Eyhm+uD468TO6pnm5AsvXgJcK67X7JKDEJEwqb5FmYnpyc4RrraF8UmSwlYcs NFWwPKPBJSOpq1DX6bzqgLh/ticV4GVt0b5O7ULzUwBFmfMbkeWE1bLYahKJZ5+9XXTwUhwJiL7ed bhTSuPmw0kyEfj/ptp/PuBciYBJdhod9ECMH3FLWx8qcoGCeXKlO7gm2BAEmie1djvH9ZLBwEY9Q4 We/GMZ99CpMoTGOkX+4Ypg5LZviZzDzKtn5KjrXQBNRSalACfHrcxt8lVrsoDLFBJDrmuQyrShk1A kKjv42Yw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l298Q-00FRAi-Av; Wed, 20 Jan 2021 08:46:39 +0000 Date: Wed, 20 Jan 2021 08:46:38 +0000 From: Christoph Hellwig To: "J. Bruce Fields" Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Trond Myklebust , Anna Schumaker , Chuck Lever Subject: Re: [PATCH 2/3] nfsd: move change attribute generation to filesystem Message-ID: <20210120084638.GA3678536@infradead.org> References: <1611084297-27352-1-git-send-email-bfields@redhat.com> <1611084297-27352-3-git-send-email-bfields@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1611084297-27352-3-git-send-email-bfields@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Jan 19, 2021 at 02:24:56PM -0500, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > After this, only filesystems lacking change attribute support will leave > the fetch_iversion export op NULL. > > This seems cleaner to me, and will allow some minor optimizations in the > nfsd code. Another indirect call just to fetch the change attribute (which happens a lot IIRC) does not seem very optimal to me. And the fact that we need three duplicate implementations also is not very nice.