Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp376878pxb; Thu, 21 Jan 2021 09:08:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRTsUVTOQc0n7fDbU9XbtqKLlrvZdW1/sRqz66FmhxFW2xBLDiIHU8GwLfnkQbjMuCE6Uv X-Received: by 2002:a05:6402:22a8:: with SMTP id cx8mr127074edb.32.1611248914694; Thu, 21 Jan 2021 09:08:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611248914; cv=none; d=google.com; s=arc-20160816; b=MDf5NFlbbbCTKFP94so4N+vMoXiujfAejFzSG5Va3MiXAUlhkxU3DGeZ1Lr7v95BIT QZfTyq0BHKZczKA8oPl6ew87pMOjfq5GrDFAJhwmfa/biJQOSaDde9kwO7QGDnPeLQij y+b8FvJnl/ORO18xvIfn4+z7s6ppD6yig1NjznFaLAlMJsteOPVS5kbxESUK7WNWyUqb y61ld33PgBMCyiXhobzIHBoxnIRDZvEdfavuS+5lLOzvgmQ0KAzbiKun7mgZJvZKDJ5z X4mMMHI1bKUzC9+K384bKrr6S39PuwzMhIohVnMhvohnIZYGrchiyK9bY9miKlNjEllR mxdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WXp9P2+4ttOF7WOJ6N6+oYIjL/n1xFJfDmqOtrJBLpU=; b=DNL+a0fOkpmqa4AhsOZSeKj92+aY8gqAmHsai+Lp5N+BOZjYnb7hF5L2Me51QRWETU T+AvT8Yg8Prtvmr6hvbAl6k9+k7+EVuUgakAd+dfsq69YeLOZeUtNKzMM8ZvfLs8QFDX qEgTOnAFX72v4dHQbG9QiN2jM4XmxELNpAWal3aiKrwLrgvCCHsWCCiLqYzyL6Kl3s0l uVqTjacAA1At4ITspxvH63WxIPOFwInvXDFGp5XqqddgNm5xP6pL8RpxH94tK8VLMkgg DHE5h0rvz3qgRvKFwlgwDqflwiOtAkhn9wr5Aw+gc5i0LElp7X1n4YDCyyPsu/IV4AJB Dm5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=gd4BKa4i; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id br22si2031649ejb.431.2021.01.21.09.08.01; Thu, 21 Jan 2021 09:08:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=gd4BKa4i; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388426AbhAURGg (ORCPT + 99 others); Thu, 21 Jan 2021 12:06:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388405AbhAURGK (ORCPT ); Thu, 21 Jan 2021 12:06:10 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70E41C06178B; Thu, 21 Jan 2021 09:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WXp9P2+4ttOF7WOJ6N6+oYIjL/n1xFJfDmqOtrJBLpU=; b=gd4BKa4iFPPuT/lD2l4BSb7o3D CcZwhIeTFXpXFqJD7zm1KvhSW779Tw+VeuicSpzqOYgmQKe4y9bE4q0XwrV2FsRd0k3PdBFb+bpW/ /RQs1TEqLYPidsbGr4wAwL0sHpKJEn9FCbbWRyhRHuoVk0i8QSB3Imxpsokzc9D3i8gabl7lj5xpS le/fJd0Q0THs9DBKuCcPcXJ4dZYELr7B/+V5dHjXnOgJjAHd+4JqUCv/DNHbG0Ng2PVhcxqxNrhGg e1ahOjpwMV0H6IKQqoBM0no7vfgQSDJsKHdBSL6kx7XXLhD8nhdOpQ3cL9dT1JDTT5SYOU8uSpxtx fdX0PhQg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l2dNh-00HIE9-Vn; Thu, 21 Jan 2021 17:04:26 +0000 Date: Thu, 21 Jan 2021 17:04:25 +0000 From: Christoph Hellwig To: Guoqing Jiang Cc: axboe@kernel.dk, linux-block@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-ide@vger.kernel.org, linux-mmc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 2/2] block: remove unnecessary argument from blk_execute_rq Message-ID: <20210121170425.GB4120717@infradead.org> References: <20210121142905.13089-1-guoqing.jiang@cloud.ionos.com> <20210121142905.13089-3-guoqing.jiang@cloud.ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121142905.13089-3-guoqing.jiang@cloud.ionos.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Jan 21, 2021 at 03:29:05PM +0100, Guoqing Jiang wrote: > We can remove 'q' from blk_execute_rq as well after the previous change > in blk_execute_rq_nowait. Same trivial nits as for the other one. Otherwise this looks good to me.