Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp381273pxb; Thu, 21 Jan 2021 09:13:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCEaofKT1spxMNW/e9/ijl5YnvNSQzr1hBDh0+D9MPCe6E7pNX2jFpMc2g3yOUObYlPPlq X-Received: by 2002:a17:906:3a0d:: with SMTP id z13mr349509eje.2.1611249229556; Thu, 21 Jan 2021 09:13:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611249229; cv=none; d=google.com; s=arc-20160816; b=xthXhUQdCSFFLnxbNP6kEfzCKKrOL1AxK24za8CnOuTsnfv4iHO5hb2ftiaPTg4QwE Vi18tK3bFICPDY+Z4JaSkBkmv4cAuYf1/nr71FLiL/tiixOGtwbviNiDf3Pk5fob6mfx zIwis5LiJs6fBybxnF0X/LdO0jgqT1ih7GQedJv9zWM3Fz5JIZSdH7deBmcs78MbqvsU XuOeQfjMW9SQPX4CJcyTU7AtZ5976UESOO4t8kJlicUPtKJgWfpgSnyooaL+cUzXIs75 dw5Sop+Afmb1gxXZIpgY7ZjKU/18SryaraiegfySDcsp7XcIzl1a54CzcbOxxkdsy6T1 1iAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QzyNyEp1YsTE5vSV+3cDru2rTzeX2CsFjS3xBz6a990=; b=wzEsSUvw3Rhpc3AvC9ad3M4khCmDno+0DRZRT1zIJMG/taZfeU3QK56qxt8LGdzVAW fkK7zbln4AP6hnLPs0Ihow/bgU59qrTK/Kws0XLFN921C3i9ZSkS79Zc4VnJrVyVxbRx VLb/tAchmTDROo5EXDLb6m4tq8yiDqq5LK1n1TovmgOhaAlAjB9D/on6lhEP6dXL1bSP sreMFEOzVk6ZffTTq7pNwNwNMAmwbGBB01Uz+r5vfagyLFRerOEtmcOsZKLPXDRVhqBj ve3BcHEyTxvyfAuNL9hqEf9EW3ObXRDzqptsG6I5fTA9LKjmr3o3rMKL4+wsgmZ6wtHF 3gCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="m/sCpkjO"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k25si2463788edq.373.2021.01.21.09.13.26; Thu, 21 Jan 2021 09:13:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="m/sCpkjO"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388340AbhAURLc (ORCPT + 99 others); Thu, 21 Jan 2021 12:11:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388298AbhAURE5 (ORCPT ); Thu, 21 Jan 2021 12:04:57 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EABDDC0613D6; Thu, 21 Jan 2021 09:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QzyNyEp1YsTE5vSV+3cDru2rTzeX2CsFjS3xBz6a990=; b=m/sCpkjOMCVgP4VoWYhFT+pNFA XsN5cp/1QMUAEvRGYKVrcCWtT0K0Qc1rUYrY8tnWtvRBGAzYQF1aJcWF3PjXrGGN5DB6crvK52Uhq VmNi8hTrqhlV+i2i9NAfj+R5YQr9uVin10+P+GGGvl4s+Wro8U/2/QQy8nAXo/5hPnH9AZL+NWlnM toPoiBaqrmygPeFA0pi51swSnxTXmB2rXAaBa2z16O2JBwXvSZdc+MGy9skDIY3SNinDpyuqYtJ3N cyelbC61FxOX5f44I6+AYEzvIq/k8mhEfUgaLp9Knoar2TChae7OQQlHwtAFdMat/0mm5SWvcQ2ZF 9pImn9Kw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l2dMH-00HI8V-2u; Thu, 21 Jan 2021 17:03:07 +0000 Date: Thu, 21 Jan 2021 17:02:57 +0000 From: Christoph Hellwig To: Guoqing Jiang Cc: axboe@kernel.dk, linux-block@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-ide@vger.kernel.org, linux-mmc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/2] block: remove unnecessary argument from blk_execute_rq_nowait Message-ID: <20210121170257.GA4120717@infradead.org> References: <20210121142905.13089-1-guoqing.jiang@cloud.ionos.com> <20210121142905.13089-2-guoqing.jiang@cloud.ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121142905.13089-2-guoqing.jiang@cloud.ionos.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Jan 21, 2021 at 03:29:04PM +0100, Guoqing Jiang wrote: > The 'q' is not used since commit a1ce35fa4985 ("block: remove dead > elevator code"), also update the comment of the function. And more importantly it never really was needed to start with given that we can triviall derive it from struct request. > -extern void blk_execute_rq_nowait(struct request_queue *, struct gendisk *, > +extern void blk_execute_rq_nowait(struct gendisk *, > struct request *, int, rq_end_io_fn *);