Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp902418pxb; Fri, 22 Jan 2021 02:01:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJyiMT+KhOqeS8QWPttQSTW704s5BEopjrR0vR5wv/yWy8ztgYLcAdJZMuTEcovpEbE+7d0W X-Received: by 2002:a50:9f65:: with SMTP id b92mr2561245edf.74.1611309715863; Fri, 22 Jan 2021 02:01:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611309715; cv=none; d=google.com; s=arc-20160816; b=l81r+jQsXnIprO4QwiM+5bD2TZia8o/USdvwXH4ibTUoEQnK0GUdgsfTfZGwOdN/G3 iFvlOW5UlLuNU260dtAv+/f0Utu65DrAhSD7H+JCuRoTmYNPoW0O0DXQMpXAwtFbrbkM upB59m79JUqB2mTSuxE6jkslRBtfYTh7x+5xvO2P/UPwABwY4bWC0OTSPgu5ODXNnU7I ORpUcbw7dbJZXA1JKNDC0p7h/8YhgWvEuWmrm/MBE9XXcuUxoVrhDM4Tgr80fMWysEHk QHLQGlM41bGa43bo/7vgpvgEJrvTNv1jzs8QLinlEacXAOoSf6BlJDc4PcEmOJrUwOP7 dEPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=HqmXNnhOvww/se+uqGpbG2r6Wj6LjG3RtqIoCGkH17k=; b=LYUp75Gs7vEOMu81+KNMM/Yd3bVX653dmI6QevJNL/EWUkjSngDDlSWpeYJ7tCEjyA B393mMcpRUPPc/kIVFfyk3GJv7n0KoquWGYHVycJuReNVG4yML9LESVrdC8Cr5ptXdeI 2iJERWdCk/RtrEGL/w4HEqTwtLr7WXABMSdcyovkJXzrKChW+lCX8M1S869OJ7C+1e36 1wl02ixHubCGkyv32BhfeJ9cKPlVXuORvbwmG1s7HOtkAiyMIfuqL+SR8N/jysrHnp9C Ur5NL787wPrJT88Uy6izIHCMNKWGRH1poRpRsC2ELKv4o/iWUbV2ToZ7u5nGMkeilMqM SWvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Bqt3b8b7; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x12si2793859ejf.85.2021.01.22.02.01.18; Fri, 22 Jan 2021 02:01:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Bqt3b8b7; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbhAVKAW (ORCPT + 99 others); Fri, 22 Jan 2021 05:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727764AbhAVKAL (ORCPT ); Fri, 22 Jan 2021 05:00:11 -0500 Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE51C0617A7 for ; Fri, 22 Jan 2021 01:50:56 -0800 (PST) Received: by mail-vs1-xe34.google.com with SMTP id h11so2672204vsa.10 for ; Fri, 22 Jan 2021 01:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HqmXNnhOvww/se+uqGpbG2r6Wj6LjG3RtqIoCGkH17k=; b=Bqt3b8b7kp2zQsjWv07hRffU5ZdsKDvLLb7CTBAQdsqsw2qRHDDv257TenVn8PQ0eh 7Faa1tfN668wJ7fnNrENLH7AoZ+Yz7eIgCNhVFIajtS786Ovqkv97Wr+V6k7E2k62MxY +zFfZILJZPCMb2mgb5PIp7UG3mhyPOfuQoIscUoL7KcMmyArbnUdaC0O1T1v40yAIWCH kb3Y/uHtCaFYyztgZ4c9IexZUktiJQ8TjmoyT1uO1aGHIVI3c5zzudaDyrdeK9RYpTX9 cIrmQQoHomR+23NhDIIBOqW/csi0rItWAjz9B7IdKkogQi35H0szd9iVKvGtnr3lgOid vpug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HqmXNnhOvww/se+uqGpbG2r6Wj6LjG3RtqIoCGkH17k=; b=oOpvmEnwxaB5ZghDlxu5nTNifUw9I7u6rMKpEpkSHpyjbtvIjvIlBOHTj0LX94ayNm BvmEp9uc6BXiJRAwCAl5MXl8ggH0XI2Sqo/5+ZP4SLlZwBS5gwhXlyLgZW34VhZTjFxF tMjzho8PfFk9gJlexn9rvnV1HKaBIc4nct+o2qKod8rIyXCd/gTeq6mYvQ5sLWcSl449 KVvVPKVqzHDP9VWlWnha+DAewMOA/JKaUx45fDWn3GJ+D9s5vLX179I/1cWmcWbJ45/J 2I5z+T0G3y3uuMB/pj7HrGyAL+9+erAXrfQxSCKoAdUeJ3CSxA5KWSPs0j9+jMlJyeky 1Y5w== X-Gm-Message-State: AOAM530Bg2dLPYA4qyQExNyalc961KuuB7c8BG+7Qzcl9kHBa2nWIAxp 9Y9ruc2o0s8aLNb+9eJrLoN2bPXZBvvuXyQciX/yoQ== X-Received: by 2002:a67:f997:: with SMTP id b23mr235525vsq.34.1611309056136; Fri, 22 Jan 2021 01:50:56 -0800 (PST) MIME-Version: 1.0 References: <20210122092824.20971-1-guoqing.jiang@cloud.ionos.com> <20210122092824.20971-3-guoqing.jiang@cloud.ionos.com> In-Reply-To: <20210122092824.20971-3-guoqing.jiang@cloud.ionos.com> From: Ulf Hansson Date: Fri, 22 Jan 2021 10:50:20 +0100 Message-ID: Subject: Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq To: Guoqing Jiang , Jens Axboe Cc: Christoph Hellwig , linux-nfs@vger.kernel.org, linux-scsi , "linux-mmc@vger.kernel.org" , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-block , linux-ide@vger.kernel.org, target-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang wrote: > > We can remove 'q' from blk_execute_rq as well after the previous change > in blk_execute_rq_nowait. > > And more importantly it never really was needed to start with given > that we can trivial derive it from struct request. > > Cc: linux-scsi@vger.kernel.org > Cc: virtualization@lists.linux-foundation.org > Cc: linux-ide@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-nvme@lists.infradead.org > Cc: linux-nfs@vger.kernel.org > Signed-off-by: Guoqing Jiang [...] > drivers/mmc/core/block.c | 10 +++++----- [...] From mmc point of view, please add: Acked-by: Ulf Hansson At the moment I don't think this will conflict with any changes to mmc, but if that happens let's sort it then... Kind regards Uffe