Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3553653pxb;
        Mon, 25 Jan 2021 21:09:47 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxz8iKwlVWrk0ia7GWhGKi+NZlGLNSRcBKUp0LEViaFW6y7VczSW/MME34tzsa+rYVQ0l98
X-Received: by 2002:a05:6402:134b:: with SMTP id y11mr3159060edw.88.1611637787785;
        Mon, 25 Jan 2021 21:09:47 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1611637787; cv=none;
        d=google.com; s=arc-20160816;
        b=YeaOHbqnxF3GRVcm16n9mbpPPisEiRJo51pp8RM7lu0pQhbdcU0W0ny1Jhms50bMIr
         VKr0htTCVgpsf60PbPX63hSTBSCbfxnU/9ahR+A39FLp7OCVTr3T8npBTURQWiYtf+Ch
         nhNb/mvBN2UQgCf5v3InPtUS3UX3lkXELE7sOotYUePSfXM1d5urOO+kp1wZfgV9FL6B
         3plhUVUYRihJniE1WMgfxIVbXRo8BdFknCNR3tTmr6I0BgS8RP2IaZg9RqGRAK0N6t7h
         ln30rzq3x5mmVU02Bu7m5Uk4Xzi36XDZmc53vgtAPR+O0swL0OKH3DSHf16Pg83gGnNm
         tLnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=hD2dihblVyt6KB5ToLRdOaDt4RozgYV/Q1Wqm2r3jOY=;
        b=X2LEldoJ0lgYUHTn+fSaZDHCp/tOruSpUu2PjfSF3IzAemeYJk0ueYK7tMdC+wxdkE
         OXgao05fJM8mWhWr4uPTnvGzIP27o1MPm4YSRbVDEpJfDvEwBO+e/EHQEA2tmaZTj/Cu
         fb9bkasrXODndg0XD26XjcuwA+zCGs+7xeTfv6C4lBtRxEJsH7uJw5OEZ/iNHfUrtL8e
         KF/jQDGqnjuJq2ALJ54O/6KlJSXoEurJ4ubjvp/7D3ygWV3xhleAxIPdG5oB78afyeU3
         bW4JDIqvlK+K8l8iqWDIE0hXQMieV6r62kxCz5IOL+QoueRxAeywQLcykeYNgqfjrbLJ
         jNqg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=szZsJUgS;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p26si6788538eji.9.2021.01.25.21.09.24;
        Mon, 25 Jan 2021 21:09:47 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=szZsJUgS;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728983AbhAZFHX (ORCPT <rfc822;hackintoshfive@gmail.com>
        + 99 others); Tue, 26 Jan 2021 00:07:23 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51096 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732055AbhAZECB (ORCPT
        <rfc822;linux-nfs@vger.kernel.org>); Mon, 25 Jan 2021 23:02:01 -0500
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95C3FC061573;
        Mon, 25 Jan 2021 20:01:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=hD2dihblVyt6KB5ToLRdOaDt4RozgYV/Q1Wqm2r3jOY=; b=szZsJUgSPGV0So2PjEzFyqt/aC
        GyEdr/UfGs5HvOaNfsGT7dgq77B941sKj9PgjAiBVacsv+FjgHkISHdLslYmTYf1TJpPBI4v4n8VN
        tCoGlH5IE+nObbCOW5VcGClxU5HrmAcNo6QfAyI2RNielNHDjb5Ua55lwdfhnweC/J6+4y17D+wK9
        HJx9AvKZcyAojIUH1mGBcP1Om+RT61Mn2SwfXusPhV5FNUh35gRES0yVHZrB37n89RJbSt+otpvLV
        I/8+MuqVC1vrReyVomu9bSFbG476zcpu3zwgqFXRU4fMPPp0xzdZk2918xuvVp2TtHUVwnsIA4aXb
        ohW+E04Q==;
Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux))
        id 1l4FVp-0052nr-00; Tue, 26 Jan 2021 03:59:44 +0000
Date:   Tue, 26 Jan 2021 03:59:28 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     David Howells <dhowells@redhat.com>
Cc:     Trond Myklebust <trondmy@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        Steve French <sfrench@samba.org>,
        Dominique Martinet <asmadeus@codewreck.org>,
        Dave Wysochanski <dwysocha@redhat.com>,
        Jeff Layton <jlayton@redhat.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
        linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
        ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 25/32] NFS: Clean up nfs_readpage() and nfs_readpages()
Message-ID: <20210126035928.GJ308988@casper.infradead.org>
References: <161161025063.2537118.2009249444682241405.stgit@warthog.procyon.org.uk>
 <161161054970.2537118.5401048451896267742.stgit@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <161161054970.2537118.5401048451896267742.stgit@warthog.procyon.org.uk>
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Mon, Jan 25, 2021 at 09:35:49PM +0000, David Howells wrote:
> -int nfs_readpage(struct file *file, struct page *page)
> +int nfs_readpage(struct file *filp, struct page *page)

I appreciate we're inconsistent between file and filp, but we're actually
moving more towards file than filp.