Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3918133pxb; Tue, 26 Jan 2021 07:56:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzlezLauKwJAReJErt3IjAiaNMV6CSnrzotkGMIsAp42RBjKxoqLzoYrnNARNv/ziZyYRa8 X-Received: by 2002:a05:6402:3514:: with SMTP id b20mr4437039edd.100.1611676583345; Tue, 26 Jan 2021 07:56:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611676583; cv=none; d=google.com; s=arc-20160816; b=AHPskgdJxt2ja6SvzklRt7IoI6OdfCCyneEdrACyuTut9Gb6FpEaFsp1T3QaVMgt14 F+zoJS4kH+eFHBB7QmKjeQgv5TsW6iR1/raEQeck3cZ2CyC4fXy07iEevRBNdCYARhMz bNSZWbcRg0CezAx4kwjQJDUXQtOK81U3nxa6TCNYPZWuVk/lQhPaIQGeJtgyOA+JSGrU SVK6cTJ+sqo2EcUUPMUyZzXNbn01tXg49arPuDkECHn+rBEREkjFiKrhd8Rn8i3IGwcP j103l4OfjOddRKioAJRrZEG5tdNqW34d7HzSoWi/IDTWp1Qz7rrjzkmTMWNucswJ2bhK eEFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+sg4yNwZrAUtqGjsjAIZF/lC9W6Hi56SguvTv3qRusA=; b=iGXlge4JnR7UkL9gf6wIaYUU8rTiQMsBxbK97VRytsxYQfU0OPGfkZxYtMhGqHrOAl 2t5VtV9m833yfc8sEX74J10dbLG4jQB0pY1WSGmNwp6ywjpBdrKS3R1ciLLU7Kg1YKxR D34ABc1Ey5gIo+ZcAn4FEsEAorrfo6hvwh1GNovCCVBpHrjbHXq4irJ8YjIuibnlPz2I yijRf7QEKCYhvPV8gNDuQkcvNncVs0n6qj5c2/LSCccHKlbA56DNB7B358T0Y6TVn4nl fDV0u4kDFFg515zm3jyst4B+guDysUyy/O1OXoLiRS0DxU1Zbq68CMouX6iX0DbOjoCA 4gWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AvAimHzo; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l20si5601436ejx.471.2021.01.26.07.55.37; Tue, 26 Jan 2021 07:56:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AvAimHzo; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391343AbhAZPlt (ORCPT + 99 others); Tue, 26 Jan 2021 10:41:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36677 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391719AbhAZPgF (ORCPT ); Tue, 26 Jan 2021 10:36:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611675278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+sg4yNwZrAUtqGjsjAIZF/lC9W6Hi56SguvTv3qRusA=; b=AvAimHzoNnyt6HHce6CcX+chG4tX7GRBMoCQqfIxXhqI8JNTZLdVRQ5eCsiWDp3LoQW+Ll BeRU+iGXcpfeyr40dWf/CDbUTRRooyC2d0rayKu4vV7JNCkHFFE87e7d5qPvPql+tPM8IL LMZSLZtAFSNufeHw3Gm8odSA9k8MABg= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-I4mLiNNJP62GVrXjZWaElQ-1; Tue, 26 Jan 2021 10:34:36 -0500 X-MC-Unique: I4mLiNNJP62GVrXjZWaElQ-1 Received: by mail-ed1-f70.google.com with SMTP id w4so9540601edu.0 for ; Tue, 26 Jan 2021 07:34:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+sg4yNwZrAUtqGjsjAIZF/lC9W6Hi56SguvTv3qRusA=; b=dB4xaMb6rFqvV1uA3FD4B2sazQCm1oUkMlVfRTK+xoj1n9lYhTTQUCzGg5Bdm7XrzY /g2o8tdQ+6jhB05xrUsjX7Hf45n7TuFrI6y/sldzKbIZSPohgVJT2XieRbjVmIUMyEzQ jJ7v6UUK8B/IHzXhYbJZBwr7JiSkK4QMBXjyQDkr4HLQyj89aG4xAH1C3dSIYBTyxdb2 mpcxQmzEcWl5ehpxsArbu39DlBZn9Mr1qkQvABGMWomDgzXJJvsxzHl5m8ffoQLN5BOz i/5574ORCBI/+7XnaEuGI3LqNVt9pRrcS0s9EKE7jPz9vk7oioHaGvF8gjMwUeXg38OW sjDw== X-Gm-Message-State: AOAM53152I8ESJuAhazB3xno/wPE8h0HnsydF1TEe/Ci2DoXywj1A9Kd P4Uw8iZao0AyM+xyMI1C0JT/hq75fHFWfE8pWpBimLWnNUpz1tOsO/FvyDooSdS7DdLWrbsKG4e I8CCO+334Ka2XliauDVQ2XXDv0GCCKbHQgr6l X-Received: by 2002:a17:906:4451:: with SMTP id i17mr2289508ejp.436.1611675275260; Tue, 26 Jan 2021 07:34:35 -0800 (PST) X-Received: by 2002:a17:906:4451:: with SMTP id i17mr2289493ejp.436.1611675275099; Tue, 26 Jan 2021 07:34:35 -0800 (PST) MIME-Version: 1.0 References: <161161025063.2537118.2009249444682241405.stgit@warthog.procyon.org.uk> <161161054970.2537118.5401048451896267742.stgit@warthog.procyon.org.uk> <20210126035928.GJ308988@casper.infradead.org> In-Reply-To: <20210126035928.GJ308988@casper.infradead.org> From: David Wysochanski Date: Tue, 26 Jan 2021 10:33:59 -0500 Message-ID: Subject: Re: [PATCH 25/32] NFS: Clean up nfs_readpage() and nfs_readpages() To: Matthew Wilcox Cc: David Howells , Trond Myklebust , Anna Schumaker , Steve French , Dominique Martinet , Jeff Layton , Alexander Viro , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs , linux-cifs , ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Jan 25, 2021 at 11:01 PM Matthew Wilcox wrote: > > On Mon, Jan 25, 2021 at 09:35:49PM +0000, David Howells wrote: > > -int nfs_readpage(struct file *file, struct page *page) > > +int nfs_readpage(struct file *filp, struct page *page) > > I appreciate we're inconsistent between file and filp, but we're actually > moving more towards file than filp. > Got it, easy enough to change.