Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2329269pxb; Fri, 29 Jan 2021 22:05:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwCRrHpqUCnH393n/tKZV/QDA7hTNkhNCN7mZFDWA88zKD2OU48Dfe4zAzEkJGOYKq6KE0j X-Received: by 2002:a17:906:796:: with SMTP id l22mr7842730ejc.247.1611986735508; Fri, 29 Jan 2021 22:05:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611986735; cv=none; d=google.com; s=arc-20160816; b=lctzyBhCpJApYX+jCZnsipvrPofvqtvIQoB0NNAmB/6p2GyIhn9SIh7tdhCU9bgKip +gD+H1XBGqvTGZgojipGyyJwmxVADFnlHWydF7ieHy4Qs9g2cTHaFKCHAHIsJhFoj7uH Ly1UM1tmP6HOXQqZIpYAP2vPhaA5YRgMBA5I5pvr9byeZ6Nbx/raK7zI0/x9PaqAg0fM kuLHl1cCettQ2xeytVkhijedWCh/Cr6w/LX8aWxyFvlVI53nPradPgRNPWut2CI9GsA9 cVwNmtw16WKQ5Rz2riHpJlaRZh5Q8KNmHu0ChgpiNfeq5rl5iexLbk+t4YwVrMAdPAPb A44Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ulTijpS/LBioTo1ylP63hfNPHictEmvbFArlgqbeXJ4=; b=yR2ZaYQFfil1GY1e8rYaZ1d8UCynloNdMTJtYRDFMBnwMxYuC3zNF5fdCIkYPh8Abg 3uhGQ8m64FQSGrNft2Qc/oOczgLI1ebzXch9rbWj+1bNId4I22aHM72Owd4HhYR2+qwy IB5ABsvg1QcFdsFfadsdrnhkN0YZoEaAleVrEoHWgRxwpmeQ/JQxyhL0yW5RdZ0j1U0B UjRsB7Fo7Z5ewzYkSPiGjlsezNx7c9qbQHfAu2V5VulSWjGCMDnfFx4ACZRPNGZc+L3D 0uG61q2NjzGTIfOl8BJ9Nh4Z+/XdGTwaINeg2pSTTbjaObQ6Tb74GJQcZABG3JBAXmrS NOgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Q9MbYBzN; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d6si6492957edz.273.2021.01.29.22.05.11; Fri, 29 Jan 2021 22:05:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Q9MbYBzN; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233817AbhA3GEU (ORCPT + 99 others); Sat, 30 Jan 2021 01:04:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233819AbhA3GD3 (ORCPT ); Sat, 30 Jan 2021 01:03:29 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0D9AC06174A; Fri, 29 Jan 2021 22:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ulTijpS/LBioTo1ylP63hfNPHictEmvbFArlgqbeXJ4=; b=Q9MbYBzNEQZYWZvGwWOsx22FSO 74ZfFFf55AQJeccITM31kpIlwKmqk+Fi8PqbcdgJq2RagZh5MFfS9QuEX1VkV4pM9u/mOwsWQRv12 gRFPAwWeKlAhxnlsvw5Oc3mv6uXEvBGjx5bozyZpLzmZGw1gszCnIADoBMQr+w+NWHdxZ9vX+P7Ll QOMu5DSYUkrBJntwqJlUiVOkV6lCD3oo/NXqxC5e8z4XcvjdGlucb/4chrHY59tA4RcwduDv9QVAE TbryHhGqJ9vIxgG7SKg9fnqc3FF9iCrnhT2ZJUhhPjPmmLA37CUYxPZY/d9ow5McNMpe0STttFhkq 2KeNw8Ng==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l5jLD-00AlNA-98; Sat, 30 Jan 2021 06:02:39 +0000 Date: Sat, 30 Jan 2021 06:02:39 +0000 From: Christoph Hellwig To: "J. Bruce Fields" Cc: Christoph Hellwig , "J. Bruce Fields" , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Trond Myklebust , Anna Schumaker , Chuck Lever Subject: Re: [PATCH 2/2 v2] nfsd: skip some unnecessary stats in the v4 case Message-ID: <20210130060239.GB2564543@infradead.org> References: <1611084297-27352-1-git-send-email-bfields@redhat.com> <1611084297-27352-3-git-send-email-bfields@redhat.com> <20210120084638.GA3678536@infradead.org> <20210121202756.GA13298@pick.fieldses.org> <20210122082059.GA119852@infradead.org> <20210129192629.GC8033@fieldses.org> <20210129192701.GD8033@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210129192701.GD8033@fieldses.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, Jan 29, 2021 at 02:27:01PM -0500, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > In the typical case of v4 and an i_version-supporting filesystem, we can > skip a stat which is only required to fake up a change attribute from > ctime. > > Signed-off-by: J. Bruce Fields Looks good, Reviewed-by: Christoph Hellwig