Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3769541pxb; Mon, 1 Feb 2021 04:23:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyILUTqyIuaXIUMIe24Mmt7QxJgajYHRATKv5jey85PY5XoIT8iWsqH+ID0V0/LDRTuNtYD X-Received: by 2002:a17:906:5043:: with SMTP id e3mr17347040ejk.260.1612182204203; Mon, 01 Feb 2021 04:23:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612182204; cv=none; d=google.com; s=arc-20160816; b=0IbfwV5+O8aSMa7GHCgER758LpMmrHvFpWgy62ufpmr/Z/GtF3kDYvGjEWglCVaXgQ 2iVdZycHNFwJok3ClD8YCS/cp2oTK/hMSrWwjInJtjOLEhfAPxMh+RRsi3GcazSrxGcs wTA6bPmjGZu8HX4Ao1pfPi3TI0o3N72ST2B4CEvqvuVFn40DL6bfebOZsx0YV9mzIk2t 0tLIldZUHRZ1OPZLP0NZQqdGivZO1aay9+zWebgQOD2QHUOtsJ2IjHE4uRfMdPRplptE Jj3sNBuV+J2zsArfKg35MogZnuJ0+y6xbQlf2RDLvonf9kbDPKRr2gOX+XwgY0xTfh2l xKtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ESQnaWFIoi03pycYkB6Y3rBV7W4I8KmEGEqRt1L7SDQ=; b=hsHmW4ThLq2zFByN6oiF+CYoxcRCJs+oxj9qVJ+yDknp4VpXmEo2e1RMQ1ubBaQvUq LyNJZGPnx586bNtD61zhduh/BdFEr3NrLsJTOrnT2By4L7OV/c2vb7lA/a8t1DJTEtuK lIC8M1aONfOCHxY5VikXVamVasxOKOYTbTLYXIF2UjLKMpgRJED1AgjPjZzaWradY2/J EWtAJ5IdCVveu7gzJSNwBgIE+hnOC1ogCkRugOG5GQyMC+FcVzbg3Wm7sEP+8OZohBhP As4h5D+1FHjxAt2kwANQ9eB+8lYlqYK885VUTxwXkj0ddNEgS9LyMlfBkMns5hwEuRMQ 0abQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si10317085ejv.203.2021.02.01.04.22.52; Mon, 01 Feb 2021 04:23:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbhBAMWv (ORCPT + 99 others); Mon, 1 Feb 2021 07:22:51 -0500 Received: from verein.lst.de ([213.95.11.211]:40973 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhBAMWu (ORCPT ); Mon, 1 Feb 2021 07:22:50 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id CCB7C6736F; Mon, 1 Feb 2021 13:22:04 +0100 (CET) Date: Mon, 1 Feb 2021 13:22:04 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Jens Axboe , Song Liu , Jaegeuk Kim , Chao Yu , Philipp Reisner , Lars Ellenberg , Coly Li , Mike Snitzer , Josef Bacik , David Sterba , Damien Le Moal , Naohiro Aota , Andrew Morton , Ryusuke Konishi , linux-nilfs@vger.kernel.org, dm-devel@redhat.com, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 04/17] block: split bio_kmalloc from bio_alloc_bioset Message-ID: <20210201122204.GA22727@lst.de> References: <20210126145247.1964410-1-hch@lst.de> <20210126145247.1964410-5-hch@lst.de> <20210130035646.GH308988@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210130035646.GH308988@casper.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Sat, Jan 30, 2021 at 03:56:46AM +0000, Matthew Wilcox wrote: > On Tue, Jan 26, 2021 at 03:52:34PM +0100, Christoph Hellwig wrote: > > bio_kmalloc shares almost no logic with the bio_set based fast path > > in bio_alloc_bioset. Split it into an entirely separate implementation. > > > > Signed-off-by: Christoph Hellwig > > --- > > block/bio.c | 167 ++++++++++++++++++++++---------------------- > > include/linux/bio.h | 6 +- > > 2 files changed, 86 insertions(+), 87 deletions(-) > > This patch causes current linux-next to OOM for me when running xfstests > after about ten minutes. Haven't looked into why yet, this is just the > results of a git bisect. I've run tests on linux-next all weekend and could not reproduce the issue. Can you share your .config?